public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH V2 pve-firewall 1/1] fix #1965: cache firewall/cluster.fw file
Date: Thu, 15 Feb 2024 16:35:11 +0100	[thread overview]
Message-ID: <17f24c6b-d61d-4214-8623-d4a437143d99@proxmox.com> (raw)
In-Reply-To: <20221125144725.3231444-2-s.hrdlicka@proxmox.com>

On 11/25/22 15:47, Stefan Hrdlicka wrote:
> for large IP sets (for example > 25k) it takes noticable longer to parse the
> files, this commit caches the cluster.fw file and reduces parsing time
> 
> Signed-off-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
> ---
>  src/PVE/Firewall.pm | 108 ++++++++++++++++++++++++++++++--------------
>  1 file changed, 75 insertions(+), 33 deletions(-)
> 

Stumbled over this by accident 👻. Seems like this was never applied,
and the author has left the company since, hence they were not able to
ping this any more. Bugzilla entry [0] has been in 'PATCH AVAILABLE'
ever since this was originally posted.

The patch still seems to apply cleanly, but I did not do any
verification/testing apart from this.

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=1965

-- 
- Lukas




      reply	other threads:[~2024-02-15 15:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25 14:47 [pve-devel] [PATCH V2 pve-firewall 0/1] cache firewall/cluster.fw Stefan Hrdlicka
2022-11-25 14:47 ` [pve-devel] [PATCH V2 pve-firewall 1/1] fix #1965: cache firewall/cluster.fw file Stefan Hrdlicka
2024-02-15 15:35   ` Lukas Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17f24c6b-d61d-4214-8623-d4a437143d99@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal