From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCHi v3 manager] fix #3451 ui: ceph create osd: show custom device classes
Date: Fri, 28 Jan 2022 13:23:35 +0100 [thread overview]
Message-ID: <17b097ae-9d93-b08b-1de9-6653571f5130@proxmox.com> (raw)
In-Reply-To: <20220125085153.1451323-1-a.lauterer@proxmox.com>
On 25.01.22 09:51, Aaron Lauterer wrote:
> Showing already configured custom device classes makes it easier to
> create new OSDs with custom device classes.
>
> The Crush map contains a list of all OSDs in the cluster, including
> their device class.
> This means we can create a list of used device classes from it, avoiding
> adding another API endpoint.
>
> Fetching the crushmap should also be quite a bit less data that needs to
> be transferred, compared to the other possible nodes/<node>/ceph/osd
> endpoint, especially in larger clusters.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> changes from v2:
> - check against eslint warnings, adding two commas
>
> changes from v1:
> - template string for API call
> - API failure now throws an alert
> - used Thomas idea on how to make the list creation more concise and
> only update the combo items if we do have custom device classes
> - reverted default `comboItems` to the element definition
>
> @Thomas by using `Array.from` we can iterate over the results returned
> from matchAll and also map element [1] from the returned array as it
> actually holds the matched item.
> The unshift needed the `...` deconstruction operator as comboItems is an
> array of arrays.
I actually dropped the unshift and expanded directly:
kvField.setComboItems([...kvField.comboItems, ...classes]);
In theory this could allow a minimally slightly more efficient use, not that
it'd matter here much, but hey a line less code ;-P
>
> www/manager6/ceph/OSD.js | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2022-01-28 12:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 17:03 [pve-devel] [PATCH v2 " Aaron Lauterer
2022-01-25 8:51 ` [pve-devel] [PATCHi v3 " Aaron Lauterer
2022-01-28 12:23 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17b097ae-9d93-b08b-1de9-6653571f5130@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox