public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: applied: [PATCH qemu-server] fix #8355: qga response: properly handle left-overs from other clients
Date: Fri, 20 Nov 2026 13:00:00 +0100	[thread overview]
Message-ID: <179517598320.39194.14397669434116210765.b4-ty@b4> (raw)
In-Reply-To: <20261119140355.137355-1-f.ebner@proxmox.com>

On Thu, 19 Nov 2026 15:02:49 +0100, Fiona Ebner wrote:
> The QGA response buffer may contain left-overs from other clients if
> they didn't read the response. The check that was in place only
> compared the expected command ID and the one from the response
> numerically, which does not work if the left-over originated from a
> client with a different PID.
> 
> To be able to parse and compare the PID from a sequence number, the
> format has to be adapted first, because the mapping ($pid,$seq) ->
> int("${pid}0${seq}") is not injective. For example, 50501 can arise
> from ($pid=5,$seq=501) or ($pid=505,$seq=1). Convert the sequence
> number to octal first and use '8' as a, now uniquely identifiable,
> separator to get a bijective mapping.
> 
> [...]

Applied, thanks!

[1/1] fix #8355: qga response: properly handle left-overs from other clients
      https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=ca9efd7cd04c456182a43ee6524d21aff97dce6a




      reply	other threads:[~2026-11-20 12:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 14:02 [PATCH qemu-server] fix #8355: qga response: properly handle left-overs from other clients Fiona Ebner
2026-11-20 12:00 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179517598320.39194.14397669434116210765.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal