public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: applied: (subset) [PATCH storage 0/3] lvm: fix qcow2 images outgrowing their LV
Date: Fri, 13 Nov 2026 10:52:46 +0100	[thread overview]
Message-ID: <179456350044.39364.15345564925363270069.b4-ty@proxmox.com> (raw)
In-Reply-To: <20261113012702.864671-1-t.lamprecht@proxmox.com>

On Fri, 13 Nov 2026 02:17:22 +0100, Thomas Lamprecht wrote:
> There were reports of qcow2 images on LVM storages with
> snapshot-as-volume-chain growing beyond their LV, which pauses the VM
> with an ENOSPC I/O error.
> 
> One likely cause is deleting the oldest snapshot while the VM is
> stopped.
> FWICT the plain 'qemu-img commit' used for that drops preallocated
> clusters of the base image wherever the overlay holds zeroes, and
> guest writes to these ranges can later allocate past the end of the LV.
> So the first patch sets 'discard-no-unref' for that commit, as already
> done for running VMs and 'qemu-img convert' in qemu-server's a3a9a2ab
> ("fix #6543: use qcow2 'discard-no-unref' option when using
> snapshot-as-volume-chain").
> 
> [...]

Applied the first two patches, thanks!

[1/3] lvm: avoid qcow2 images outgrowing their LV after offline snapshot delete
      commit: 01ea0054d5237c61175df767bd400cf832fcf848
[2/3] lvm: qcow2 resize: size the LV for the cluster settings of the image
      commit: 00a8186dbefa4b15969da2d395d7e57a0bac7775




      parent reply	other threads:[~2026-11-13  9:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  1:17 [PATCH storage 0/3] lvm: fix qcow2 images outgrowing their LV Thomas Lamprecht
2026-11-13  1:17 ` [PATCH storage 1/3] lvm: avoid qcow2 images outgrowing their LV after offline snapshot delete Thomas Lamprecht
2026-11-13  1:17 ` [PATCH storage 2/3] lvm: qcow2 resize: size the LV for the cluster settings of the image Thomas Lamprecht
2026-11-13  1:17 ` [PATCH storage 3/3] lvm: qcow2: reserve LV space for persistent dirty bitmaps Thomas Lamprecht
2026-11-13  9:54   ` Fiona Ebner
2026-11-13 11:12     ` Thomas Lamprecht
2026-11-13 12:33   ` applied: " Fiona Ebner
2026-11-13  9:52 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179456350044.39364.15345564925363270069.b4-ty@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal