From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, security@proxmox.com,
Fiona Ebner <f.ebner@proxmox.com>
Cc: j.klocker@proxmox.com
Subject: applied: [PATCH-SERIES storage/guest-common/qemu-server v2 00/17] fixes and hardenings for SSH commands and volume names
Date: Fri, 6 Nov 2026 00:00:47 +0100 [thread overview]
Message-ID: <179391964449.1952644.10039698225710614080.b4-ty@b4> (raw)
In-Reply-To: <20261105092428.18326-1-f.ebner@proxmox.com>
On Thu, 05 Nov 2026 10:21:03 +0100, Fiona Ebner wrote:
> Changes in v2:
> * Rebased on current master.
> * Drop already applied patch.
>
> Add a build_ssh_command() for shell-quoting the remote part of an
> SSH command, and use it in the storage layer, replication, and for VM
> migration. Could also be used for container migration, but the
> arguments passed there are safe.
>
> [...]
Applied, thanks!
[storage] applied to pve-storage.git (master)
[01/11] test: add parse volname tests for block-based plugins
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=38c44c37a795e984869b14810da47ba80a4da5c8
[02/11] rbd: parse volname: actually require 'base' or 'vm' as prefix
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=2626dba85f8a20ab7cde2e45ee6c7f0f708d55ad
[03/11] zfs: parse volname: restrict to characters actually allowed by ZFS
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=f05d0a16c4cffa16c808a96e4104b2c7702167e3
[04/11] storage migrate: use build_ssh_command() helper
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=be0a72fd03657a2764165b4eff3a08a94b4519b6
[05/11] volume import/export prepare: separate options and arguments
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=6d5a99aa4e827fb088b5104336e2f0880ff5536a
[06/11] api: upload: use build_ssh_command() helper
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=af4562f07f9cb7a1c72b0ea42a7f65eddb733200
[07/11] api: upload: don't re-quote argument for scp command
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=bdba449664d98e5bf6a0f57316fdded2a42cd286
[08/11] zfs: use build_ssh_command() helper
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=a9d8fab584672236ec4a4996179e5b0b4ada190e
[09/11] iscsi: istgt: lun command: remove dead code
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=634f54115568497aba9e5dd6da145dc35f98f8bd
[10/11] iscsi providers: use build_ssh_command() helper
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=e1d52171563aa936916435309d7b903e99519192
[11/11] parse volname: add reminder comment to restrict allowed characters
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=f5699d531610457343877ac3238946ee8f9efad6
[guest-common] applied to pve-guest-common.git (master)
[1/3] tunnel: use build_ssh_command() helper
https://git.proxmox.com/?p=pve-guest-common.git;a=commitdiff;h=b69158a0eb1e80c754a16dabdab6172e1f584952
[2/3] replication: separate and quote arguments for ssh commands
https://git.proxmox.com/?p=pve-guest-common.git;a=commitdiff;h=556cab962e5fd7232b7ec10b7c48f2cb05873664
[3/3] replication: terminate options for pvesr commands
https://git.proxmox.com/?p=pve-guest-common.git;a=commitdiff;h=630e1fa8897e5915f1c6c92610f69b13364c9070
[qemu-server] applied to qemu-server.git (master)
[1/3] migrate: cleanup remote disks: terminate options for pvesm free command
https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=3f9b3688716a1b3910cb20498d6900a3f5ab02ea
[2/3] migrate: use build_ssh_command() helper
https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=49b435c27c95c9869add3e589c3cbf33ee3cd826
[3/3] test: migration: adapt to storage_migrate() change
https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=97d6e404e8f2e8b34d74560761cda44daf3ead35
parent reply other threads:[~2026-11-05 23:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20261105092428.18326-1-f.ebner@proxmox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179391964449.1952644.10039698225710614080.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=j.klocker@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=security@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox