From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Subject: applied: [PATCH pve-firewall] fix #8261: config parser: check prefix length without Net::IP
Date: Tue, 3 Nov 2026 15:47:15 +0100 [thread overview]
Message-ID: <179371096808.1744582.16417501069987112549.b4-ty@b4> (raw)
In-Reply-To: <20261103121014.169908-1-a.bied-charreton@proxmox.com>
On Tue, 03 Nov 2026 13:10:14 +0100, Arthur Bied-Charreton wrote:
> 99343fe ("firewall: reject cidrs with invalid netmask") made
> parse_ip_or_cidr call pve_verify_ip_or_cidr. That function masks the
> host bits and constructs a Net::IP object for every alias and IPSet
> entry, which is very expensive.
>
> As noted in the linked bug, a cluster config with about 30k IPSet
> entries took 6 seconds to parse vs. 0.4 before this call was introduced.
>
> [...]
Applied, thanks!
I folded in `\z` anchors, so a trailing newline stays rejected like with the
removed call, plus a test for that, and noted in the commit message that a
`/0` prefix with host bits set is now accepted. I also made the API accept
that in a follow-up, since clean_cidr treated a literal `/0` like a missing
prefix:
82888bc ("api: accept host bits in /0 networks like for other prefixes")
[1/1] fix #8261: config parser: check prefix length without Net::IP
commit: eea1b88b9eaf8735197943ed2f4353a4a6715069
prev parent reply other threads:[~2026-11-03 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 12:10 [PATCH pve-firewall] fix #8261: config parser: check prefix length without Net::IP Arthur Bied-Charreton
2026-11-03 14:47 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179371096808.1744582.16417501069987112549.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox