From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: applied: [PATCH storage] fix #7295: lvm plugin: rollback: keep original volume when allocation fails and saferemove is used
Date: Sun, 4 Oct 2026 21:33:30 +0200 [thread overview]
Message-ID: <179114230653.2862530.13293353231709205634.b4-ty@b4> (raw)
In-Reply-To: <20260209104009.44272-1-f.ebner@proxmox.com>
On Mon, 09 Feb 2026 11:40:00 +0100, Fiona Ebner wrote:
> When the 'saferemove' storage configuration option is used, the
> 'current' top volume of the backing chain is renamed and removal is
> delegated to a worker task. Thus, the space for that volume is still
> allocated and cannot be re-used for the new top volume (to be backed
> by the snapshot volume). With a full enough pool, allocating the new
> top volume fails. In this case, executing the saferemove worker and
> removing the 'current' volume is bad, because there won't be any top
> volume anymore. Fixing that situation would mean manually allocating a
> new top volume backed by the snapshot afterwards.
>
> [...]
Applied, thanks!
[1/1] fix #7295: lvm plugin: rollback: keep original volume when allocation fails and saferemove is used
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=75f3c5518df9571e1d6c525075bd958a1d464140
prev parent reply other threads:[~2026-10-04 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 10:40 [PATCH storage] fix #7295: lvm plugin: rollback: keep original volume when allocation fails and saferemove is used Fiona Ebner
2026-10-04 19:33 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179114230653.2862530.13293353231709205634.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox