public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: applied: [PATCH manager v4 0/2] fix #6735: api: pci: allow mdevscan access via mapping permissions
Date: Wed, 30 Sep 2026 23:08:05 +0200	[thread overview]
Message-ID: <179080248155.2638466.14975802568234452276.b4-ty@b4> (raw)
In-Reply-To: <20260904094456.70309-1-e.huhsovitz@proxmox.com>

On Fri, 04 Sep 2026 11:44:52 +0200, Elias Huhsovitz wrote:
> This series allows users who have been granted Mapping.Use
> (or Mapping.Modify / Mapping.Audit) on a specific PCI mapping to list
> the mediated device (mdev) types for that mapping without requiring
> global Sys.Audit or Sys.Modify privileges on the entire cluster.
> 
> In multi‑team environments where access is compartmentalized via
> resource pools and PCI mappings, the previous requirement forced
> administrators to grant overly broad permissions for GPU usage.
> By checking mapping‑specific permissions when a mapping name is
> supplied, the patch enables non‑administrative users to select and use
> vGPU types for their assigned hardware.
> 
> [...]

Applied the first one, but dropped the constant, thanks!

more rationale: IMO that constant name was not ideal as it was rather generic
and even if that was addressed we still had repetition here by listing the
privs explicit in the description, which can go out of sync much easier that
way. Also, not a common pattern we use in our code base and IMO also just not
gaining one that much to add such indirection variables/constants.

[1/2] fix #6735: api: pci: allow mdevscan access via mapping permissions
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=58350116c198b838dfb50739e886bc92bcc751c3
[2/2] api: pci: utilize constant perm variable for pci_scan
      DROPPED




      parent reply	other threads:[~2026-09-30 21:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04  9:44 [PATCH manager v4 0/2] fix #6735: api: pci: allow mdevscan access via mapping permissions Elias Huhsovitz
2026-09-04  9:44 ` [PATCH manager v4 1/2] " Elias Huhsovitz
2026-09-04  9:44 ` [PATCH manager v4 2/2] api: pci: utilize constant perm variable for pci_scan Elias Huhsovitz
2026-09-30 21:08 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179080248155.2638466.14975802568234452276.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=e.huhsovitz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal