public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Daniel Kral <d.kral@proxmox.com>
Subject: applied: [RFC PATCH guest-common] tunnel: treat reader_stderr as optional parameter in read_tunnel
Date: Fri,  3 Jul 2026 15:35:20 +0200	[thread overview]
Message-ID: <178308571625.160753.8329800893982790898.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260630084332.32566-1-d.kral@proxmox.com>

On Tue, 30 Jun 2026 10:43:32 +0200, Daniel Kral wrote:
> The reader_stderr parameter was introduced for a specific use case for
> the users of fork_ssh_tunnel(). The other callers, such as
> fork_websocket_tunnel(), do not provide the parameter and the Perl
> interpreter will warn about this:
> 
>     Use of uninitialized value $reader_stderr in <HANDLE> at /usr/share/perl5/PVE/Tunnel.pm line 77.
>     readline() on unopened filehandle at /usr/share/perl5/PVE/Tunnel.pm line 77.
> 
> [...]

Applied, thanks!

[1/1] tunnel: treat reader_stderr as optional parameter in read_tunnel
      commit: e10fabc1f26d73767aa984adb329a5a67b6ea57e




      parent reply	other threads:[~2026-07-03 13:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30  8:43 [RFC PATCH guest-common] tunnel: treat reader_stderr as optional parameter in read_tunnel Daniel Kral
2026-07-01 12:31 ` Stoiko Ivanov
2026-07-03 13:35 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178308571625.160753.8329800893982790898.b4-ty@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal