Re: [PATCH manager] ui: qemu: add detect zeroes disk option

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

On June 16, 2026 3:16 pm, Lukas Sichert wrote:
> On 2026-06-16 15:01, Fabian Grünbichler <f.gruenbichler@proxmox.com> wrote:
> 
>> if I am not mistaken, this is a fix for
>> https://bugzilla.proxmox.com/show_bug.cgi?id=4503 ?
> 
> Yes, I have also corrected this in a v2 already [1], but I forgot to send a
> superseded-by. Sorry for the confusion.
> 
> [1] https://lore.proxmox.com/all/20260610131827.11092-1-l.sichert@proxmox.com/

sorry, missed that (and so did b4 it seems)!

>> On June 8, 2026 10:36 am, Lukas Sichert wrote:
>>> When discard is enabled, qemu-server defaults to `detect-zeroes=unmap`.
>>> This can have a significant performance impact for zero writes on some
>>> setups, while users might still want to keep guest discard/TRIM support
>>> enabled.
>>> 
>>> Allow configuring the option independently so discard can stay enabled
>>> while zero detection is disabled. Persist the checkbox state explicitly,
>>> as the backend treats an absent value as the default-enabled behavior.
>>> 
>>> Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
>>> ---
>>>  www/manager6/qemu/HDEdit.js | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>> 
>>> diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
>>> index 1bb2bfda..d1d1b0fa 100644
>>> --- a/www/manager6/qemu/HDEdit.js
>>> +++ b/www/manager6/qemu/HDEdit.js
>>> @@ -96,6 +96,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
>>>          PVE.Utils.propertyStringSet(me.drive, values.readOnly, 'ro', 'on');
>>>          PVE.Utils.propertyStringSet(me.drive, values.cache, 'cache');
>>>          PVE.Utils.propertyStringSet(me.drive, values.aio, 'aio');
>>> +        me.drive.detect_zeroes = values.detect_zeroes ? 1 : 0;
>>
>> this should probably have a comment why this line is deviating from the
>> ones above (to not lose an explicit false value that clashes with the
>> implicit true default value of the backend.
> 
> Thanks for looking over this. I will fix it in a v3.

ack.