From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com, Shan Shaji <s.shaji@proxmox.com>
Subject: applied: [PATCH proxmox-acme] fix: acme: add missing `_json_decode` function
Date: Mon, 15 Jun 2026 11:53:52 +0200 [thread overview]
Message-ID: <178151722686.255301.1164041706004471494.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260421121212.218008-1-s.shaji@proxmox.com>
On Tue, 21 Apr 2026 14:12:12 +0200, Shan Shaji wrote:
> While placing the ACME certificate order using the Active24 plugin,
> the request was failing [0]. This was because, `_json_decode` function
> was referenced inside the dns_active24.sh file but was never defined
> in the `proxmox-acme` script.To fix it, the missing function was added
> by referencing the implementation from the acme.sh [1] script.
>
> - [0] https://forum.proxmox.com/threads/acme-active24-dns-plugin-error-json_decode-command-not-found.182899/
> - [1] https://github.com/acmesh-official/acme.sh/blob/master/acme.sh#L912
>
> [...]
Applied, thanks!
[1/1] fix: acme: add missing `_json_decode` function
commit: cf8c277f5e89dc8734fba16a4df51cf027abf97d
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
prev parent reply other threads:[~2026-06-15 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 12:12 [PATCH proxmox-acme] fix: acme: add missing `_json_decode` function Shan Shaji
2026-04-29 7:58 ` Shan Shaji
2026-06-15 7:55 ` Shan Shaji
2026-06-15 9:53 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178151722686.255301.1164041706004471494.b4-ty@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox