public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [PATCH frr v2 0/3] Backport FRR EVPN local RT2 leaking fixes
Date: Sun, 17 May 2026 01:59:45 +0200	[thread overview]
Message-ID: <177897588457.770468.8377906826309521859.b4-ty@b4> (raw)
In-Reply-To: <20260515120351.395649-1-g.goller@proxmox.com>

On Fri, 15 May 2026 14:03:44 +0200, Gabriel Goller wrote:
> Since packaging 10.6.1, we also pull in the EVPN local RT2 leaking patches
> (which are applied on upstream master).
> 
> The RT2 route leaking PR seems to have some race-condition-related problems,
> namely a crash at bgp router shutdown and one case in which the rt2 route is not
> leaked (see the last comment at #20005 [1]).
> 
> [...]

Tested thise one with 500 VXLAN+bridge churn cycles on a host with the EVPN
address-family active (no leaks, no asserts, +12 KB bgpd RSS) and a `no router
bgp` with an active VNI to exercise the new cleanup path (runs clean). The 21
commits across both upstream PRs (#21511 and #21844) were also checked against
upstream and are logically equivalent; deviations are limited to a few hunks
that account for backport-target context that doesn't exist in 10.6.1 yet, so:

Applied, thanks!

btw. I resolved the merge conflict with the other series, but it isn't perfect
git history wise - but we probably won't have to bisect these two commits on
the packaging level, or rather, one can relatively easy work around doing so.

[1/3] frr: backport "bgpd: fix valgrind memory leaks on daemon shutdown" (#21511)
      commit: 6ddac172c96f3bad0f90f5d61876e98344c33c0c
[2/3] frr: backport the "Memory leak problems." (#21844) upstream PR
      commit: 4e14853e8f9d59d47b5f35792ce6efe601601d5f
[3/3] bump to version 10.6.1-1+pve2
      commit: 9f188e1b4459edfd6174aa1ad48ee4ab6bde7749




      parent reply	other threads:[~2026-05-17  0:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 12:03 [PATCH frr v2 0/3] Backport FRR EVPN local RT2 leaking fixes Gabriel Goller
2026-05-15 12:03 ` [PATCH frr v2 1/3] frr: backport "bgpd: fix valgrind memory leaks on daemon shutdown" (#21511) Gabriel Goller
2026-05-15 12:03 ` [PATCH frr v2 2/3] frr: backport the "Memory leak problems." (#21844) upstream PR Gabriel Goller
2026-05-15 12:03 ` [PATCH frr v2 3/3] bump to version 10.6.1-1+pve2 Gabriel Goller
2026-05-16 23:59 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177897588457.770468.8377906826309521859.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal