From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com,
Lukas Wagner <l.wagner@proxmox.com>
Subject: applied: [PATCH common/proxmox{,-backup}/storage v2 0/9] establish unique instance-id for PBS nodes
Date: Wed, 13 May 2026 04:05:25 +0200 [thread overview]
Message-ID: <177863755633.3889845.18092870907983412159.b4-ty@b4> (raw)
In-Reply-To: <20260424082943.89614-1-l.wagner@proxmox.com>
On Fri, 24 Apr 2026 10:29:34 +0200, Lukas Wagner wrote:
> In PDM we require some way to match PBS storage <-> PBS remote.
>
> Having some kind of unique ID for each PBS instance should make it quite easy
> to establish such a mapping completely automatically.
>
> The general approach is
> 1.) add /nodes/localhost/server-identity route in PBS, returning a unique, per-installation ID
> 2.) add something like /nodes/.../storage/<id>/identity in PVE, which uses
> proxmox-backup-client internally to return the instance ID for this PBS storage
> 3.) PDM can then use both API routes to establish the mapping
>
> [...]
Applied now the remaining storage patches, thanks!
Fix-ups inline:
- APIVER bump: kept APIAGE bumped (no reset). get_identity is opt-in via the
new route, so resetting would re-version every external plugin for no
benefit. Also added an ApiChangeLog v14 entry so external plugin authors can
more quickly see what changed.
- /identity: fixed broken string concat in the 'id' property description.
Follow-ups on top:
- /identity: also accept Datastore.AllocateSpace (any => 1), matching the
surrounding per-storage read endpoints.
- /identity: add storage_check_enabled check, like basically all others and as
it seems sensible to not query those.
[1/3] plugin: add get_identity method
commit: cb45db06786704cfe5d5962372bf5d9f31f51e53
[2/3] bump storage plugin APIVER and APIAGE
commit: 336e508b50e0145a5c6b9b5ee3b7886fd010dc94
[3/3] api: add /nodes/<node>/storage/<storage>/identity route
commit: f4f617adb8dedd2a02375d3b44b98e28611f71f4
prev parent reply other threads:[~2026-05-13 2:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 8:29 [PATCH common/proxmox{,-backup}/storage v2 0/9] establish unique instance-id for PBS nodes Lukas Wagner
2026-04-24 8:29 ` [PATCH proxmox v2 1/9] pbs-api-types: add ServerIdentity response type Lukas Wagner
2026-04-24 8:29 ` [PATCH proxmox v2 2/9] systemd: add support for machine-id generation Lukas Wagner
2026-04-24 8:29 ` [PATCH proxmox-backup v2 3/9] api: add /nodes/localhost/identity Lukas Wagner
2026-04-24 8:29 ` [PATCH proxmox-backup v2 4/9] client: add 'server-identity' sub-command Lukas Wagner
2026-04-24 8:29 ` [PATCH proxmox-backup v2 5/9] manager: add 'server-identity' subcommand Lukas Wagner
2026-04-24 8:29 ` [PATCH common v2 6/9] pbs-client: add support for the 'server-identity' command Lukas Wagner
2026-05-12 22:52 ` applied: [PATCH common/proxmox{,-backup}/storage v2 0/9] establish unique instance-id for PBS nodes Thomas Lamprecht
2026-04-24 8:29 ` [PATCH pve-storage v2 7/9] plugin: add get_identity method Lukas Wagner
2026-04-24 8:29 ` [PATCH pve-storage v2 8/9] bump storage plugin APIVER and reset APIAGE Lukas Wagner
2026-04-24 8:29 ` [PATCH pve-storage v2 9/9] api: add /nodes/<node>/storage/<storage>/identity route Lukas Wagner
2026-04-24 21:24 ` partially-applied: [PATCH common/proxmox{,-backup}/storage v2 0/9] establish unique instance-id for PBS nodes Thomas Lamprecht
2026-05-13 2:05 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177863755633.3889845.18092870907983412159.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox