From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, David Riley <d.riley@proxmox.com>
Subject: applied: [PATCH pve-manager v2 0/1] fix: #4490 ui: backup job window: add search for virtual guest grid
Date: Wed, 13 May 2026 02:33:50 +0200 [thread overview]
Message-ID: <177863242554.3618550.18412291321944223153.b4-ty@b4> (raw)
In-Reply-To: <20260327103801.104735-1-d.riley@proxmox.com>
On Fri, 27 Mar 2026 11:38:00 +0100, David Riley wrote:
> This v2 implements the suggested stop-gap solution for filtering the
> virtual guest selection in the backup job edit window.
>
> Differences from v1:
> - Drop the complex collapsible filter panel (tags, pools, HA State)
> This avoids the UX trap of users thinking the filters apply
> dynamically at job runtime (deferring that feature for a proper
> implementation of #4186 [0]).
> - Add search text-field in the grid toolbar to filter by
> Name or VMID.
> - Add a "Review" toggle checkbox in the bottom toolbar that limits
> the grid view to only currently selected guests.
> - Add a "Selected (X)" counter in the bottom toolbar for immediate
> visual feedback.
> - Override the `getValue` collection logic to gather data directly
> from the SelectionModel, ensuring virtual guests hidden by the
> Search filter are still correctly submitted.
>
> [...]
Applied, thanks! FYI: I factored the now ~three time existing search widget out
into a common module in a follow-up and did some minor adaptions.
[1/1] fix: #4490 ui: backup job window: add search for virtual guest grid
commit: 7ad74616a0b7bd5f8999a28f429963980298f9e9
next prev parent reply other threads:[~2026-05-13 0:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 10:38 [PATCH pve-manager v2 0/1] fix: #4490 ui: backup job window: add search for virtual guest grid David Riley
2026-03-27 10:38 ` [PATCH pve-manager v2 1/1] " David Riley
2026-04-27 12:14 ` [PATCH pve-manager v2 0/1] " David Riley
2026-05-13 0:33 ` Thomas Lamprecht [this message]
2026-05-13 6:44 ` applied: " David Riley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177863242554.3618550.18412291321944223153.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=d.riley@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox