From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com, Robert Obkircher <r.obkircher@proxmox.com>
Subject: applied: [pve-devel] [PATCH v2 proxmox-ve-rs] fix #6399: firewall: fix parsing rule comments that contain hash signs
Date: Mon, 4 May 2026 14:52:22 +0200 [thread overview]
Message-ID: <177789911575.631096.655963133568499090.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251215123925.168475-1-r.obkircher@proxmox.com>
On Mon, 15 Dec 2025 13:38:58 +0100, Robert Obkircher wrote:
> Match the behavior of the corresponding perl code in parse_fw_rule and
> treat everything after the first '#' on a line as the comment. This
> works because validation prevents fields like the interface name from
> contianing that symbol.
>
> This fixes a bug where the firewall wouldn't start if a comment on a
> rule contained a number sign.
>
> [...]
Applied, thanks!
[1/1] fix #6399: firewall: fix parsing rule comments that contain hash signs
commit: d598628c17bd5da1f3a0bf1fd4e81dc7e51dbcec
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
prev parent reply other threads:[~2026-05-04 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 12:38 [pve-devel] [PATCH v2 proxmox-ve-rs] fix #6399: firewall: fix parsing rule comments that contain hash signs Robert Obkircher
2026-04-30 12:32 ` Robert Obkircher
2026-05-04 12:52 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177789911575.631096.655963133568499090.b4-ty@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=r.obkircher@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox