public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, Shan Shaji <s.shaji@proxmox.com>
Subject: applied: [PATCH pve_flutter_frontend 0/2] fix: broken functionality flagged by google play console
Date: Wed, 22 Apr 2026 11:04:57 +0200	[thread overview]
Message-ID: <177684866765.1073926.18264332330893357089.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260422085517.71782-1-s.shaji@proxmox.com>

On Wed, 22 Apr 2026 10:55:15 +0200, Shan Shaji wrote:
> The tokens and groups tab bar view were showing an empty page if there are
> no groups or tokens. The behaviour was similliar to our web UI, but
> Google Play Console flagged that behaviour as a broken functionality. To fix
> the issue, if there are no groups or tokens a placeholder text will be shown.
> 
> Shan Shaji (2):
>   fix: ui: show empty message if there are no tokens or groups
>   cleanup: run `dart format` to fix formatting of the main_layout file
> 
> [...]

Applied, thanks!

[1/2] fix: ui: show empty message if there are no tokens or groups
      commit: a13157397e413e4fd912008303b984fafeab359d
[2/2] cleanup: run `dart format` to fix formatting of the main_layout file
      commit: 641de7f066eccd0c08261afd804970351f0995a6




      parent reply	other threads:[~2026-04-22  9:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22  8:55 Shan Shaji
2026-04-22  8:55 ` [PATCH pve_flutter_frontend 1/2] fix: ui: show empty message if there are no tokens or groups Shan Shaji
2026-04-22  8:55 ` [PATCH pve_flutter_frontend 2/2] cleanup: run `dart format` to fix formatting of the main_layout file Shan Shaji
2026-04-22  9:04 ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177684866765.1073926.18264332330893357089.b4-ty@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.shaji@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal