From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, Shan Shaji <s.shaji@proxmox.com>
Subject: applied: [PATCH proxmox_dart_api_client 1/1] fix: cleanup: dart analysis issues found by dart linter
Date: Thu, 2 Apr 2026 13:37:39 +0200 [thread overview]
Message-ID: <177512979589.2426970.9411523956747356829.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260306143530.113174-2-s.shaji@proxmox.com>
On Fri, 06 Mar 2026 15:35:29 +0100, Shan Shaji wrote:
> The library name is not necessary anymore [0]. Removed the same
> and updated the doc comments. Additionaly, added explicit types
> for variables as suggested by the dart linter (lints) [1][2].
>
> [0] - https://dart.dev/tools/linter-rules/unnecessary_library_name
> [1] - https://dart.dev/tools/linter-rules/prefer_typing_uninitialized_variables
> [2] - https://dart.dev/tools/linter-rules/strict_top_level_inference
>
> [...]
Applied, thanks!
[1/1] fix: cleanup: dart analysis issues found by dart linter
commit: 5258fd14c908306a237f5242ef965d7fdb9d3bda
next prev parent reply other threads:[~2026-04-02 11:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 14:35 [PATCH proxmox{_dart_api_client,_login_manager} 0/2] cleanup: replace deprecated property and fix dart analyze issues Shan Shaji
2026-03-06 14:35 ` [PATCH proxmox_dart_api_client 1/1] fix: cleanup: dart analysis issues found by dart linter Shan Shaji
2026-04-02 11:37 ` Dominik Csapak [this message]
2026-03-06 14:35 ` [PATCH proxmox_login_manager 1/1] cleanup: replace use of deprecated props and fix dart analyze issues Shan Shaji
2026-04-02 11:37 ` applied: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177512979589.2426970.9411523956747356829.b4-ty@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox