From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [PATCH manager] api: backup: add return schema for backup jobs
Date: Wed, 1 Apr 2026 13:47:00 +0200 [thread overview]
Message-ID: <177504401807.2730483.184909672933706926.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260327152015.394455-1-l.wagner@proxmox.com>
On Fri, 27 Mar 2026 16:20:15 +0100, Lukas Wagner wrote:
> The GET /cluster/backup and /cluster/backup/<jobid> endpoints were
> missing a proper return value schema. The schema properties themselves
> were copied from the POST call, but needed to be slightly adapted.
>
> - id is a pve-backup-jobid, since this is what was used before
> - fleecing, performance and prune-backups are submitted as a property
> string, but returned as a proper JSON object, so these needed to be
> overridden from the base config that stems from pve-guest-common
> - 'next-run' was added
>
> [...]
Applied this now, but please see my other reply for potentially dropping dow
and starttime completely here (which is IMO best done as follow-up), thanks!
[1/1] api: backup: add return schema for backup jobs
commit: 0e85aecd829f838c5eb41f7655502a492ba651bd
prev parent reply other threads:[~2026-04-01 11:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 15:20 Lukas Wagner
2026-04-01 9:55 ` Thomas Lamprecht
2026-04-01 10:01 ` Lukas Wagner
2026-04-01 11:46 ` Thomas Lamprecht
2026-04-01 14:11 ` Lukas Wagner
2026-04-01 11:47 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177504401807.2730483.184909672933706926.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox