From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, David Riley <d.riley@proxmox.com>
Subject: applied: [PATCH pve-manager v3 0/2] fix #7300: acl path include pre-generated zones and fabrics
Date: Thu, 19 Mar 2026 00:01:12 +0100 [thread overview]
Message-ID: <177387486864.691685.1363325205490334184.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260313122602.59579-1-d.riley@proxmox.com>
On Fri, 13 Mar 2026 13:26:00 +0100, David Riley wrote:
> Thanks for the feedback.
>
> Differences from v2:
> * moved var to let conversion to a seperate commit
> * using record.get instead of direct data access
>
> Differences from v1:
> * Add signature
>
> [...]
Applied, thanks!
But I expanded/reworked the commit messages a bit to provide further rationale,
no worries, for a first series this was pretty good already, but maybe check
out the changes I made to see what you could maybe do different/improve for a
next series. If you got any questions here (or have remarks for my changes),
feel encouraged to just ask directly.
[1/2] ui: replace var with let
commit: 0c015d0ca2ae093a8db70e7fc97a254d71609788
[2/2] fix #7300: acl path include pre-generated zones and fabrics
commit: 3aefa09998a51f955537568af59b6e851cc6d063
prev parent reply other threads:[~2026-03-18 23:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 12:26 David Riley
2026-03-13 12:26 ` [PATCH pve-manager v3 1/2] ui: replace var with let David Riley
2026-03-13 12:26 ` [PATCH pve-manager v3 2/2] fix #7300: acl path include pre-generated zones and fabrics David Riley
2026-03-18 23:01 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177387486864.691685.1363325205490334184.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.riley@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox