public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH docs 2/2] firmware-updates: add group header to fwupd.conf
Date: Mon, 16 Mar 2026 16:10:17 +0100	[thread overview]
Message-ID: <1773673775.igibui0ihp.astroid@yuna.none> (raw)
In-Reply-To: <s8oecljrieo.fsf@toolbox>

On March 16, 2026 2:52 pm, Maximiliano Sandoval wrote:
> Fabian Grünbichler <f.gruenbichler@proxmox.com> writes:
> 
>> On December 29, 2025 2:39 pm, Maximiliano Sandoval wrote:
>>> After creating a new config file, either as daemon.conf or fwupd.conf
>>> with the same contents as the example prior to this commit, the
>>> following error will be seen when starting fwupd.service:
>>> 
>>> Failed to load daemon: failed to load engine: Failed to load config: failed to load /etc/fwupd/fwupd.conf: Key file does not start with a group
>>> 
>>> Since there are potentially multiple groups, adding this at the end of
>>> the file might result in the key added to the wrong group. The file is
>>> also not present by default, so creating it without the header will also
>>> lead to issues. On the other hand, adding the group multiple times is
>>> not an issue.
>>> 
>>> Please see `man 5 fwupd.conf` for more details.
>>> 
>>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>>> ---
>>>  firmware-updates.adoc | 1 +
>>>  1 file changed, 1 insertion(+)
>>> 
>>> diff --git a/firmware-updates.adoc b/firmware-updates.adoc
>>> index 9ca4b6e..b9ca47e 100644
>>> --- a/firmware-updates.adoc
>>> +++ b/firmware-updates.adoc
>>> @@ -57,6 +57,7 @@ mount point of the EFI partition in `/etc/fwupd/fwupd.conf`, for example:
>>>  
>>>  .File `/etc/fwupd/fwupd.conf`
>>>  ----
>>> +[fwupd]
>>>  # Override the location used for the EFI system partition (ESP) path.
>>>  EspLocation=/boot/efi
>>
>> does this still work/did you actually test this change?
>>
>> AFAIK, fwupd now requires udisk to lookup the ESP, it is no longer
>> possible to override this:
>>
>> https://bugzilla.proxmox.com/show_bug.cgi?id=6654
> 
> You are right, it does not work. Would it be OK to remove the following
> from the documentation
> 
> ```
> That means you must explicitly configure the correct
> mount point of the EFI partition in `/etc/fwupd/daemon.conf`, for example:
> 
> .File `/etc/fwupd/daemon.conf`
> ```
> 
> for now?

probably. and we should test whether there are still blockers for
udisks2, and/or how to integrate fwupd with proxmox-boot-tool based
setups if there still are some..




  reply	other threads:[~2026-03-16 15:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-29 13:39 [pve-devel] [PATCH docs 1/2] firmware-updates: replace dameon.conf with fwupd.conf Maximiliano Sandoval
2025-12-29 13:39 ` [pve-devel] [PATCH docs 2/2] firmware-updates: add group header to fwupd.conf Maximiliano Sandoval
2026-01-15 14:42   ` Fabian Grünbichler
2026-03-16 13:52     ` Maximiliano Sandoval
2026-03-16 15:10       ` Fabian Grünbichler [this message]
2026-03-16 15:56         ` superseded: " Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1773673775.igibui0ihp.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal