[PATCH container/qemu-server v3 0/2] api: clone: print a message with new VMID

[PATCH container/qemu-server v3 0/2] api: clone: print a message with new VMID

[Maximiliano Sandoval]

Note that when creating linked clones we do not update the creation time (commits)
in the config.

When cloning two VMs from a template (created with "vanilla" settings),
if one uses the same 'name' for both clones, then the only differences
between the linked clones that could be used to tell them apart are the
MAC address, the VM id, smbios UUID, and the vmgenid, all of which are
randomly generated.

I think it makes sense to update the creation time too. But for now,
being able to tell from the task log which VM correspond to which
qmclone task would be an improvement already.

Tested:
 - create a template with id 101
 - running: qm clone 101 206 --full 0, and checking its output
   creating a clone of 101 with ID 206
   create linked clone of drive scsi0 (local-lvm:base-101-disk-0)

Differences from v2:
 - s/creating a clone of $vmid/creating a clone of VM $vmi
 - Add a similar line to pve-container's clone 

Differences from v1:
 - Moved the message to the start of $clonefn


qemu-server:

Maximiliano Sandoval (1):
  api: qmclone: print a message with new VMID

 src/PVE/API2/Qemu.pm | 3 +++
 1 file changed, 3 insertions(+)


pve-container:

Maximiliano Sandoval (1):
  api: vm_clone: print a message with new VMID

 src/PVE/API2/LXC.pm | 2 ++
 1 file changed, 2 insertions(+)


Summary over all repositories:
  2 files changed, 5 insertions(+), 0 deletions(-)

-- 
Generated by murpp 0.10.0

[PATCH qemu-server v3 1/2] api: qmclone: print a message with new VMID

[Maximiliano Sandoval]

When doing a linked clone of a template, the task log, journal, nor the
UPID of the task will log the VMID of the newly created VM.

We add a log message at the start of the clone. This affects both full
and linked clones.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/API2/Qemu.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index 1e226f6f..b409610c 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -4487,6 +4487,9 @@ __PACKAGE__->register_method({
         my $clonefn = sub {
             my ($conffile, $newconf, $oldconf, $vollist, $drives, $fullclone) =
                 $load_and_check->();
+
+            print("creating a clone of VM $vmid with ID $newid\n");
+
             my $storecfg = PVE::Storage::config();
 
             # auto generate a new uuid
-- 
2.47.3

[PATCH container v3 2/2] api: vm_clone: print a message with new VMID

[Maximiliano Sandoval]

When doing a linked clone of a template, the task log, journal, nor the
UPID of the task will log the VMID of the newly created container.

We add a log message at the start of the clone. This affects both full
and linked clones.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/API2/LXC.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 7841215..a5bf1aa 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -2134,6 +2134,8 @@ __PACKAGE__->register_method({
 
             my $newvollist = [];
 
+            print("creating a clone of container $vmid with ID $newid\n");
+
             my $verify_running = PVE::LXC::check_running($vmid) || 0;
             die "unexpected state change\n" if $verify_running != $running;
 
-- 
2.47.3

applied: [PATCH container/qemu-server v3 0/2] api: clone: print a message with new VMID

[Fiona Ebner]

On Mon, 16 Mar 2026 13:38:17 +0100, Maximiliano Sandoval wrote:
> Note that when creating linked clones we do not update the creation time (commits)
> in the config.
> 
> When cloning two VMs from a template (created with "vanilla" settings),
> if one uses the same 'name' for both clones, then the only differences
> between the linked clones that could be used to tell them apart are the
> MAC address, the VM id, smbios UUID, and the vmgenid, all of which are
> randomly generated.
> 
> [...]

Applied, thanks!

[1/2] api: qmclone: print a message with new VMID
      commit: 5c1f10e08ad5699756945c6a979a79109b687dd1
[2/2] api: vm_clone: print a message with new VMID
      commit: de9544a04a701fcf2386b2bf659d2571448660dc