public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH ha-manager v2] lrm: fix typos in log messages
@ 2026-03-12  8:39 Dominik Rusovac
  2026-03-15 19:18 ` Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Rusovac @ 2026-03-12  8:39 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
---
 changes since v1:
 * adjust regression test affected by changes

 src/PVE/HA/LRM.pm                               | 6 +++---
 src/test/test-stale-maintenance-node/log.expect | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm
index e4b0ec8..09a965c 100644
--- a/src/PVE/HA/LRM.pm
+++ b/src/PVE/HA/LRM.pm
@@ -376,7 +376,7 @@ sub work {
     } elsif ($state eq 'active') {
 
         if ($fence_request) {
-            $haenv->log('err', "node need to be fenced - releasing agent_lock\n");
+            $haenv->log('err', "node needs to be fenced - releasing agent_lock\n");
             $self->set_local_status({ state => 'lost_agent_lock' });
         } elsif (!$self->get_protected_ha_agent_lock()) {
             $self->set_local_status({ state => 'lost_agent_lock' });
@@ -406,7 +406,7 @@ sub work {
         if ($fence_request) {
             $haenv->log(
                 'err',
-                "node need to be fenced during maintenance mode - releasing agent_lock\n",
+                "node needs to be fenced during maintenance mode - releasing agent_lock\n",
             );
             $self->set_local_status({ state => 'lost_agent_lock' });
         } elsif ($self->active_service_count() || $self->run_workers()) {
@@ -518,7 +518,7 @@ sub work {
             if ($service_count > 0) {
                 $haenv->log(
                     'err',
-                    "get shutdown request in state 'lost_agent_lock' - "
+                    "got shutdown request in state 'lost_agent_lock' - "
                         . "detected $service_count running services",
                 );
 
diff --git a/src/test/test-stale-maintenance-node/log.expect b/src/test/test-stale-maintenance-node/log.expect
index 2713132..092db8b 100644
--- a/src/test/test-stale-maintenance-node/log.expect
+++ b/src/test/test-stale-maintenance-node/log.expect
@@ -47,9 +47,9 @@ info    144     shutdown: execute power node3 off
 info    160    node1/crm: status change master => lost_manager_lock
 info    160    node1/crm: status change lost_manager_lock => wait_for_quorum
 info    161    node1/lrm: status change maintenance => lost_agent_lock
-err     161    node1/lrm: get shutdown request in state 'lost_agent_lock' - detected 1 running services
-err     181    node1/lrm: get shutdown request in state 'lost_agent_lock' - detected 1 running services
-err     201    node1/lrm: get shutdown request in state 'lost_agent_lock' - detected 1 running services
+err     161    node1/lrm: got shutdown request in state 'lost_agent_lock' - detected 1 running services
+err     181    node1/lrm: got shutdown request in state 'lost_agent_lock' - detected 1 running services
+err     201    node1/lrm: got shutdown request in state 'lost_agent_lock' - detected 1 running services
 info    202     watchdog: execute power node1 off
 info    201    node1/crm: killed by poweroff
 info    202    node1/lrm: killed by poweroff
-- 
2.47.3





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-15 19:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-12  8:39 [PATCH ha-manager v2] lrm: fix typos in log messages Dominik Rusovac
2026-03-15 19:18 ` Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal