public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH manager] fix #7386: ui: make memory window compatible with older browsers again
@ 2026-03-10  9:10 Dominik Csapak
  2026-03-10 11:42 ` applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2026-03-10  9:10 UTC (permalink / raw)
  To: pve-devel

while this is supported in most modern browsers, it's not supported in
(still updated) older Firefox ESR versions.

This was introduced in ECMAscript version 2025, which is against our
style guide that suggests we should stick to ES 2024 features for
trixie.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
Usually I'd not go back with such things, but since it's just a one line
fix and technically the code was against our style guide, i think it's
fine.


 www/manager6/qemu/MemoryEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/qemu/MemoryEdit.js b/www/manager6/qemu/MemoryEdit.js
index ff4a7545..0f6bd656 100644
--- a/www/manager6/qemu/MemoryEdit.js
+++ b/www/manager6/qemu/MemoryEdit.js
@@ -65,7 +65,7 @@ Ext.define('PVE.qemu.MemoryInputPanel', {
         }
 
         if (deleteSet.size > 0) {
-            res.delete = deleteSet.keys().toArray().join(',');
+            res.delete = Array.from(deleteSet.keys()).join(',');
         }
 
         return res;
-- 
2.47.3





^ permalink raw reply	[flat|nested] 2+ messages in thread

* applied: [PATCH manager] fix #7386: ui: make memory window compatible with older browsers again
  2026-03-10  9:10 [PATCH manager] fix #7386: ui: make memory window compatible with older browsers again Dominik Csapak
@ 2026-03-10 11:42 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-03-10 11:42 UTC (permalink / raw)
  To: pve-devel, Dominik Csapak

On Tue, 10 Mar 2026 10:10:42 +0100, Dominik Csapak wrote:
> while this is supported in most modern browsers, it's not supported in
> (still updated) older Firefox ESR versions.
> 
> This was introduced in ECMAscript version 2025, which is against our
> style guide that suggests we should stick to ES 2024 features for
> trixie.
> 
> [...]

Applied, rework the commit message to include a bit more explicit details and
references for posterity , thanks!

[1/1] fix #7386: ui: make memory window compatible with older browsers again
      commit: 29d2a43a6696d8912fe12c307fffcad641722ad5




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-10 11:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-10  9:10 [PATCH manager] fix #7386: ui: make memory window compatible with older browsers again Dominik Csapak
2026-03-10 11:42 ` applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal