public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH proxmox-biome] add pgettext and npgettext to JavaScript globals
@ 2026-02-28  6:13 Kefu Chai
  2026-03-10  7:52 ` Kefu Chai
  2026-03-10  9:09 ` applied: " Dominik Csapak
  0 siblings, 2 replies; 3+ messages in thread
From: Kefu Chai @ 2026-02-28  6:13 UTC (permalink / raw)
  To: pve-devel; +Cc: Kefu Chai

From: Kefu Chai <tchaikov@gmail.com>

These context-aware gettext functions are now being used in
proxmox-i18n projects and need to be recognized as valid
global functions by biome to prevent undefined variable
errors during 'make deb'.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 src/biome.json | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/biome.json b/src/biome.json
index cda44243..ea8709be 100644
--- a/src/biome.json
+++ b/src/biome.json
@@ -128,7 +128,9 @@
             "Proxmox",
             "eslint",
             "ngettext",
-            "gettext"
+            "gettext",
+            "pgettext",
+            "npgettext"
         ]
     }
 }
-- 
2.47.3





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH proxmox-biome] add pgettext and npgettext to JavaScript globals
  2026-02-28  6:13 [PATCH proxmox-biome] add pgettext and npgettext to JavaScript globals Kefu Chai
@ 2026-03-10  7:52 ` Kefu Chai
  2026-03-10  9:09 ` applied: " Dominik Csapak
  1 sibling, 0 replies; 3+ messages in thread
From: Kefu Chai @ 2026-03-10  7:52 UTC (permalink / raw)
  To: Thomas Lamprecht, Kefu Chai, pve-devel; +Cc: Kefu Chai

Hi Thomas,

Could you please help review this change? It would help us to add the
context-aware support to our gettext-based i18n.

cheers,

On Sat Feb 28, 2026 at 2:13 PM CST, Kefu Chai wrote:
> From: Kefu Chai <tchaikov@gmail.com>
>
> These context-aware gettext functions are now being used in
> proxmox-i18n projects and need to be recognized as valid
> global functions by biome to prevent undefined variable
> errors during 'make deb'.
>
> Signed-off-by: Kefu Chai <k.chai@proxmox.com>
> ---
>  src/biome.json | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/biome.json b/src/biome.json
> index cda44243..ea8709be 100644
> --- a/src/biome.json
> +++ b/src/biome.json
> @@ -128,7 +128,9 @@
>              "Proxmox",
>              "eslint",
>              "ngettext",
> -            "gettext"
> +            "gettext",
> +            "pgettext",
> +            "npgettext"
>          ]
>      }
>  }





^ permalink raw reply	[flat|nested] 3+ messages in thread

* applied: [PATCH proxmox-biome] add pgettext and npgettext to JavaScript globals
  2026-02-28  6:13 [PATCH proxmox-biome] add pgettext and npgettext to JavaScript globals Kefu Chai
  2026-03-10  7:52 ` Kefu Chai
@ 2026-03-10  9:09 ` Dominik Csapak
  1 sibling, 0 replies; 3+ messages in thread
From: Dominik Csapak @ 2026-03-10  9:09 UTC (permalink / raw)
  To: pve-devel, Kefu Chai

On Sat, 28 Feb 2026 14:13:20 +0800, Kefu Chai wrote:
> These context-aware gettext functions are now being used in
> proxmox-i18n projects and need to be recognized as valid
> global functions by biome to prevent undefined variable
> errors during 'make deb'.
> 
> 

Applied, thanks!

[1/1] add pgettext and npgettext to JavaScript globals
      commit: cd4de506ca14e858519978e50108bb3ab8122405




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-10  9:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-28  6:13 [PATCH proxmox-biome] add pgettext and npgettext to JavaScript globals Kefu Chai
2026-03-10  7:52 ` Kefu Chai
2026-03-10  9:09 ` applied: " Dominik Csapak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal