[PATCH ha-manager v3 0/2] resources: Expand max_restart option

[PATCH ha-manager v3 0/2] resources: Expand max_restart option

[Maximiliano Sandoval]

When read next to `max_relocate` it is not clear which happens first after a
resource fails to start.

Differences from v2:
 - Rename services to resources.

Differences from v1:
 - Incorporate feedback. Namely, "the service will be attempted to be relocated"
   was a bit too convoluted.

Maximiliano Sandoval (2):
  resources: use resource instead of service on descriptions
  resources: Expand max_restart option

 src/PVE/HA/Resources.pm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

-- 
2.47.3

[PATCH ha-manager v3 1/2] resources: use resource instead of service on descriptions

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/HA/Resources.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm
index 68d9d16..7af776c 100644
--- a/src/PVE/HA/Resources.pm
+++ b/src/PVE/HA/Resources.pm
@@ -72,7 +72,7 @@ EODESC
             default => 1,
         },
         max_restart => {
-            description => "Maximal number of tries to restart the service on"
+            description => "Maximal number of tries to restart the resource on"
                 . " a node after its start failed.",
             type => 'integer',
             optional => 1,
@@ -80,8 +80,8 @@ EODESC
             minimum => 0,
         },
         max_relocate => {
-            description => "Maximal number of service relocate tries when a"
-                . " service fails to start.",
+            description => "Maximal number of resource relocate tries when a"
+                . " resource fails to start.",
             type => 'integer',
             optional => 1,
             default => 1,
-- 
2.47.3

[PATCH ha-manager v3 2/2] resources: Expand max_restart option

[Maximiliano Sandoval]

When read next to `max_relocate` it is not clear which happens first
after a resource fails to start.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/HA/Resources.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm
index 7af776c..c770900 100644
--- a/src/PVE/HA/Resources.pm
+++ b/src/PVE/HA/Resources.pm
@@ -73,7 +73,8 @@ EODESC
         },
         max_restart => {
             description => "Maximal number of tries to restart the resource on"
-                . " a node after its start failed.",
+                . " a node after its start failed. When reached, the HA manager will try to"
+                . " relocate the resource to an eligible node.",
             type => 'integer',
             optional => 1,
             default => 1,
-- 
2.47.3

applied: [PATCH ha-manager v3 0/2] resources: Expand max_restart option

[Thomas Lamprecht]

On Wed, 04 Mar 2026 09:35:56 +0100, Maximiliano Sandoval wrote:
> When read next to `max_relocate` it is not clear which happens first after a
> resource fails to start.
> 
> Differences from v2:
>  - Rename services to resources.
> 
> Differences from v1:
>  - Incorporate feedback. Namely, "the service will be attempted to be relocated"
>    was a bit too convoluted.
> 
> [...]

Applied, thanks!

[1/2] resources: use resource instead of service on descriptions
      commit: ffb0f9aa4dfd6c2eb08bfeeeed0eda3c1f31f30e
[2/2] resources: Expand max_restart option
      commit: 0217fe64379ef0919b89486f27311c597aa09cac