public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Mayr <stefan@mayr-stefan.de>
Subject: Re: [pve-devel] [PATCH common, container, manager and pmg-api v2 0/4] Fix #7175: replace timezone handling with systemd timedatectl
Date: Thu, 19 Feb 2026 09:13:54 +0100	[thread overview]
Message-ID: <1771488809.jsn0vgncfe.astroid@yuna.none> (raw)
In-Reply-To: <7b42c9a6-98fe-41c9-926b-b11d35f1e700@mayr-stefan.de>

On February 18, 2026 8:53 pm, Stefan Mayr wrote:
> Am 25.01.2026 um 22:01 schrieb Stefan Mayr:
>> Second try to fix #7175. These patches remove direct /etc/timezone
>> handling, add timezone functions to the Systemd module and replaces all
>> uses of the functions you pointed me to.
>> 
>> This time it is with a verification of valid timezones.
>> 
>> It does not address hardcoded timezones in the javascript for the UI or
>> the rust code handling timezones.
>> 
>> Trying to provide patches to Proxmox is the first time I have to use
>> an email based patch workflow. I'm pretty sure sending these patches for
>> four different repos the way I do it currently is not 100% how it is
>> intended to be done. So please forgive me.
>> 
>> Suggested-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
>> Suggested-by: Maximiliano Sandroval <m.sandoval@proxmox.com>
>> Signed-off-by: Stefan Mayr <stefan@mayr-stefan.de>
> 
> Any feedback on my suggestions to fix the timezone handling?

Sorry, I haven't gotten around yet to doing another pass over it, I'll
try to fit it in this week or start of the next one!

Fabian




  reply	other threads:[~2026-02-19  8:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-25 21:01 Stefan Mayr
2026-01-25 21:01 ` [pve-devel] [PATCH manager v2 1/4] " Stefan Mayr
2026-01-25 21:01 ` [pve-devel] [PATCH container v2 2/4] " Stefan Mayr
2026-01-25 21:01 ` [pve-devel] [PATCH pmg-api v2 3/4] " Stefan Mayr
2026-01-25 21:01 ` [pve-devel] [PATCH common v2 4/4] " Stefan Mayr
2026-02-18 19:53 ` [pve-devel] [PATCH common, container, manager and pmg-api v2 0/4] " Stefan Mayr
2026-02-19  8:13   ` Fabian Grünbichler [this message]
2026-02-20 11:48 ` Stoiko Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1771488809.jsn0vgncfe.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=stefan@mayr-stefan.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal