public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Filip Schauer <f.schauer@proxmox.com>, pve-devel@lists.proxmox.com
Subject: applied-series: [PATCH container/manager v2 0/2] make mount point attribute preservation configurable
Date: Thu, 12 Feb 2026 15:31:13 +0100	[thread overview]
Message-ID: <1770906662.z8hucbu2md.astroid@yuna.none> (raw)
In-Reply-To: <20260211144111.123837-1-f.schauer@proxmox.com>

thanks!

On February 11, 2026 3:41 pm, Filip Schauer wrote:
> The commit 0db559517ac6 (mountpoint_insert_staged: inherit attributes if
> directory already exists) introduced automatic propagation of uid, gid,
> and mode from the target directory to the mounted filesystem. While this
> improves compatibility with some OCI images, it also caused undesired
> ownership changes on some mount points.
> 
> Since attribute preservation is not always desired, make this behavior
> configurable via a new "keepattrs" mountpoint flag. Default to disabled
> to preserve historical behavior.
> 
> Patch 2/2 exposes this flag in the UI and depends on patch 1/2.
> 
> Changed since v1:
> * Improve descriptions of new "keepattrs" flag
> 
> pve-container:
> 
> Filip Schauer (1):
>   make mount point attribute preservation configurable
> 
>  src/PVE/LXC.pm            | 4 +---
>  src/PVE/LXC/Config.pm     | 9 +++++++++
>  src/lxc-pve-prestart-hook | 2 +-
>  3 files changed, 11 insertions(+), 4 deletions(-)
> 
> 
> pve-manager:
> 
> Filip Schauer (1):
>   ui: lxc/MPEdit: add "keepattrs" flag
> 
>  www/manager6/lxc/MPEdit.js | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> 
> Summary over all repositories:
>   4 files changed, 26 insertions(+), 4 deletions(-)
> 
> -- 
> Generated by git-murpp 0.6.0
> 
> 
> 
> 
> 




      parent reply	other threads:[~2026-02-12 14:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 14:41 Filip Schauer
2026-02-11 14:41 ` [PATCH container v2 1/2] " Filip Schauer
2026-02-11 14:41 ` [PATCH manager v2 2/2] ui: lxc/MPEdit: add "keepattrs" flag Filip Schauer
2026-02-12 14:31 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1770906662.z8hucbu2md.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=f.schauer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal