public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Filip Schauer <f.schauer@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager 2/2] ui: lxc/MPEdit: add "keepattrs" flag
Date: Wed, 11 Feb 2026 14:49:40 +0100	[thread overview]
Message-ID: <1770817692.il72sr0e6w.astroid@yuna.none> (raw)
In-Reply-To: <20260211110657.50811-3-f.schauer@proxmox.com>

On February 11, 2026 12:06 pm, Filip Schauer wrote:
> Expose the "keepattrs" flag for mount points in the UI.
> 
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>

Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>

> ---
> This depends on patch 1/2.
> 
>  www/manager6/lxc/MPEdit.js | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/www/manager6/lxc/MPEdit.js b/www/manager6/lxc/MPEdit.js
> index f4c45876..4bba536c 100644
> --- a/www/manager6/lxc/MPEdit.js
> +++ b/www/manager6/lxc/MPEdit.js
> @@ -47,6 +47,7 @@ Ext.define('PVE.lxc.MountPointInputPanel', {
>          setMPOpt('ro', values.ro);
>          setMPOpt('acl', values.acl);
>          setMPOpt('replicate', values.replicate);
> +        setMPOpt('keepattrs', values.keepattrs);
>  
>          let res = {};
>          res[confid] = PVE.Parser.printLxcMountPoint(me.mp);
> @@ -338,6 +339,20 @@ Ext.define('PVE.lxc.MountPointInputPanel', {
>              name: 'replicate',
>              fieldLabel: gettext('Skip replication'),
>          },
> +        {
> +            xtype: 'proxmoxcheckbox',
> +            name: 'keepattrs',
> +            defaultValue: '0',
> +            fieldLabel: gettext('Keep Attributes'),
> +            autoEl: {
> +                tag: 'div',
> +                'data-qtip': gettext('Preserve Attributes of Target Directory'),

nit: this is not a heading/label, so it should have regular casing?

> +            },
> +            bind: {
> +                hidden: '{isRoot}',
> +                disabled: '{isRoot}',
> +            },
> +        },
>      ],
>  });
>  
> -- 
> 2.47.3
> 
> 
> 
> 
> 
> 




      reply	other threads:[~2026-02-11 13:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 11:06 [PATCH container/manager 0/2] make mount point attribute preservation configurable Filip Schauer
2026-02-11 11:06 ` [PATCH container 1/2] " Filip Schauer
2026-02-11 13:49   ` Fabian Grünbichler
2026-02-11 14:43     ` superseded: " Filip Schauer
2026-02-11 11:06 ` [PATCH manager 2/2] ui: lxc/MPEdit: add "keepattrs" flag Filip Schauer
2026-02-11 13:49   ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1770817692.il72sr0e6w.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=f.schauer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal