public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: applied: [PATCH proxmox-i18n v2 0/5] Fix formats of translated strings
Date: Wed,  4 Feb 2026 18:37:25 +0100	[thread overview]
Message-ID: <177022664202.822433.11697802703105334755.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260204134835.422155-1-m.sandoval@proxmox.com>

On Wed, 04 Feb 2026 14:48:28 +0100, Maximiliano Sandoval wrote:
> Fix translation which would produce errors at runtime when substituting
> variables when formatting the string. Also adds a msgfmt --check make target.
> 
> See commit messages.
> 
> Differences from v1:
>  - Adds a check target to make
>  - Fix more strings
>  - Mark as fuzzy instead of marking as untranslated
>  - Reword commit messages
>  - Remove javascript-format flag from that one message
> 
> [...]

Applied, thanks!

btw. gettext 0.26 shouldn't be that far out in debian anymore [0], once
it'spackaged we could look into how much trouble backporting that version would
be. Maybe we could add a small perl version of your wrong format check script
and integrate that with the build system directly too.

[0]: https://lists.debian.org/debian-devel/2026/02/msg00033.html

[1/5] ja: remove second plural form
      commit: 99fb0e182756bb3b7c4224431df313828b4681ed
[2/5] fix strings with wrong format
      commit: ed4a3ea148dbbacde0756e58a6901b5153a57719
[3/5] make: remove javascript-format flag from extracted strings
      commit: fdfe0a0d9b681b7240228f5bdf1c52fc47812bad
[4/5] run make do_update
      commit: 00d492afa74fb338bdfcdecacfc006639693f4d3
[5/5] make: add check target
      commit: 7feb0cb41b0b186ffa3ffb56e721bffa96e6664f




      parent reply	other threads:[~2026-02-04 17:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 13:48 Maximiliano Sandoval
2026-02-04 13:48 ` [PATCH proxmox-i18n v2 1/5] ja: remove second plural form Maximiliano Sandoval
2026-02-04 13:48 ` [PATCH proxmox-i18n v2 2/5] fix strings with wrong format Maximiliano Sandoval
2026-02-04 13:48 ` [PATCH proxmox-i18n v2 3/5] make: remove javascript-format flag from extracted strings Maximiliano Sandoval
2026-02-04 13:48 ` [PATCH proxmox-i18n v2 4/5] run make do_update Maximiliano Sandoval
2026-02-04 13:48 ` [PATCH proxmox-i18n v2 5/5] make: add check target Maximiliano Sandoval
2026-02-04 17:37 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177022664202.822433.11697802703105334755.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal