public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH ceph 4/4 v5] make: build with pkg.ceph.crimson build profile
Date: Fri, 23 Jan 2026 14:03:01 +0100	[thread overview]
Message-ID: <1769172867.62rvxoaxum.astroid@yuna.none> (raw)
In-Reply-To: <20260123075619.2731724-11-k.chai@proxmox.com>

On January 23, 2026 8:56 am, Kefu Chai wrote:
> Enable the pkg.ceph.crimson build profile to build Crimson OSD packages.
> While the previous commit added patches for Crimson support, the build
> profile must be explicitly activated to generate the ceph-osd-crimson
> package.
> 
> Additionally, add ceph-osd-classic and ceph-osd-crimson to DEBS_REST
> and DBG_DEBS so they are included in the default "all" Makefile target.

works for now - I do wonder whether it wouldn't make sense to flip this
at some point upstream and introduce a *pkg.ceph.nocrimson* profile
instead, that when set, disables all the crimson-specific bits..

but maybe it is still too early for that now :)

> 
> Signed-off-by: Kefu Chai <k.chai@proxmox.com>
> ---
>  Makefile | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 3e9749bd65f..671d84a9419 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -17,6 +17,8 @@ ceph-mds-dbg_${PKGVER}_${ARCH}.deb \
>  ceph-mgr-dbg_${PKGVER}_${ARCH}.deb \
>  ceph-mon-dbg_${PKGVER}_${ARCH}.deb \
>  ceph-osd-dbg_${PKGVER}_${ARCH}.deb \
> +ceph-osd-classic-dbg_${PKGVER}_${ARCH}.deb \
> +ceph-osd-crimson-dbg_${PKGVER}_${ARCH}.deb \
>  ceph-test-dbg_${PKGVER}_${ARCH}.deb \
>  libcephfs2-dbg_${PKGVER}_${ARCH}.deb \
>  librados2-dbg_${PKGVER}_${ARCH}.deb \
> @@ -36,6 +38,8 @@ ceph-mds_${PKGVER}_${ARCH}.deb \
>  ceph-mgr_${PKGVER}_${ARCH}.deb \
>  ceph-mon_${PKGVER}_${ARCH}.deb \
>  ceph-osd_${PKGVER}_${ARCH}.deb \
> +ceph-osd-classic_${PKGVER}_${ARCH}.deb \
> +ceph-osd-crimson_${PKGVER}_${ARCH}.deb \
>  ceph-resource-agents_${PKGVER}_${ARCH}.deb \
>  ceph-test_${PKGVER}_${ARCH}.deb \
>  libcephfs2_${PKGVER}_${ARCH}.deb \
> @@ -90,7 +94,7 @@ ${BUILDSRC}: ${SRCDIR} patches
>  deb: ${DEBS} ${DBG_DEBS}
>  ${DEBS_REST} ${DBG_DEBS}: $(MAIN_DEB)
>  $(MAIN_DEB): ${BUILDSRC}
> -	cd ${BUILDSRC}; dpkg-buildpackage -b -uc -us
> +	cd ${BUILDSRC}; dpkg-buildpackage -b -uc -us -Ppkg.ceph.crimson
>  	lintian ${DEBS}
>  	@echo ${DEBS}
>  
> -- 
> 2.47.3
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2026-01-23 13:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21 15:12 [pve-devel] [PATCH ceph] cherry-pick changes to use system packages for bundled deps Kefu Chai
2026-01-22  8:29 ` [pve-devel] [PATCH ceph] cherry-pick changes to buiild crimson package Kefu Chai
2026-01-22 10:14   ` [pve-devel] [PATCH ceph 2/3 v2] " Kefu Chai
2026-01-22 10:14   ` [pve-devel] [PATCH ceph 3/3] make: build with pkg.ceph.crimson build profile Kefu Chai
2026-01-22 10:56   ` [pve-devel] [PATCH ceph 2/3 v3] cherry-pick changes to build crimson package Kefu Chai
2026-01-22 11:43   ` [pve-devel] [PATCH ceph 2/3 v4] " Kefu Chai
2026-01-23  7:56   ` [pve-devel] [PATCH ceph 1/4 v5] cherry-pick changes to use system packages for bundled deps Kefu Chai
2026-01-23  8:18     ` Kefu Chai
2026-01-23 13:03     ` Fabian Grünbichler
2026-01-24  4:13       ` Kefu Chai
2026-01-23  7:56   ` [pve-devel] [PATCH ceph 2/4 v5] cherry-pick changes to build crimson package Kefu Chai
2026-01-23 13:03     ` Fabian Grünbichler
2026-01-24  4:45       ` Kefu Chai
2026-01-23  7:56   ` [pve-devel] [PATCH ceph 3/4 v5] exclude ceph-osd-crimson when running dwz Kefu Chai
2026-01-23 13:03     ` Fabian Grünbichler
2026-01-24  4:54       ` Kefu Chai
2026-01-23  7:56   ` [pve-devel] [PATCH ceph 4/4 v5] make: build with pkg.ceph.crimson build profile Kefu Chai
2026-01-23 13:03     ` Fabian Grünbichler [this message]
2026-01-24  4:58       ` Kefu Chai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1769172867.62rvxoaxum.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal