From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH common] rest handler: map path to methods: avoid returning misleading 'internal error'
Date: Tue, 20 Jan 2026 16:12:51 +0100 [thread overview]
Message-ID: <176892196815.1392349.8345953520894461591.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260119101554.39139-1-f.ebner@proxmox.com>
On Mon, 19 Jan 2026 11:15:41 +0100, Fiona Ebner wrote:
> When a path pointing to below a leaf endpoint is provided, for example
> '/access/acl/foobar', then when reaching the leaf endpoint, there is
> neither a regex nor subfolders to continue the lookup. This is fully
> expected, but currently an 'internal error' message will be returned
> and the only caller will log it to syslog. Returning undef instead
> avoids the misleading error log while otherwise preserving the same
> behavior as before. That is, failing the request with a clear error:
> 501 Method 'GET /access/acl/foobar' not implemented
>
> [...]
Applied, thanks!
[1/1] rest handler: map path to methods: avoid returning misleading 'internal error'
commit: a93a3d396d5e32e7daa7f502c5f8065126c85cc2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2026-01-20 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 10:15 [pve-devel] " Fiona Ebner
2026-01-20 15:12 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176892196815.1392349.8345953520894461591.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox