From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH container] fix #6392: setup: fedora: skip --prompt-new-user on firstboot
Date: Thu, 15 Jan 2026 15:19:58 +0100 [thread overview]
Message-ID: <1768486661.9u9pts34rj.astroid@yuna.none> (raw)
In-Reply-To: <20251219152009.862325-1-m.sandoval@proxmox.com>
On December 19, 2025 4:19 pm, Maximiliano Sandoval wrote:
> As per 'homectl --help':
>
> --prompt-new-user: Query user interactively for user to create
>
> which will wait on stdin to get the credentials for the new user, but at
> this point there is no way for the user to enter such input and the
> container will not start.
>
> One could alternatively remove the unit file from the
> 'systemd-firstboot(1)' step, but this incantation has valid use-cases
> like recognizing a existing homes on firstboot.
1. this makes no sense in the commit message ;)
2. I don't think homed integration makes a lot of sense for a system
container, and would rather skip it altogether
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> src/PVE/LXC/Setup/Fedora.pm | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/src/PVE/LXC/Setup/Fedora.pm b/src/PVE/LXC/Setup/Fedora.pm
> index cf383e3..891884b 100644
> --- a/src/PVE/LXC/Setup/Fedora.pm
> +++ b/src/PVE/LXC/Setup/Fedora.pm
> @@ -43,6 +43,30 @@ sub setup_init {
> 'systemd-networkd.service' => 1,
> });
> }
> +
> + if ($version >= 42) {
> + $self->skip_homectl_firstboot_prompt();
> + }
> +}
> +
> +sub skip_homectl_firstboot_prompt {
> + my ($self) = @_;
> +
> + # Replaces 'homectl firstboot --prompt-new-user' with 'homectl firstboot'.
> + # When the --prompt-new-user flag is enabled the process will wait for user
> + # input resulting in the setup process not ever finishing.
> + my $unit_path = '/usr/lib/systemd/system/systemd-homed-firstboot.service';
> + if ($self->ct_file_exists($unit_path)) {
> + my $unit = <<__EOD__;
> +# Generated by Proxmox VE
> +[Service]
> +ExecStart=
> +ExecStart=homectl firstboot
> +__EOD__
> +
> + $self->ct_make_path("$unit_path.d");
> + $self->ct_file_set_contents("$unit_path.d/50-skip-prompt.conf", $unit);
> + }
> }
>
> sub setup_network {
> --
> 2.47.3
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2026-01-15 14:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 15:19 Maximiliano Sandoval
2026-01-15 14:19 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1768486661.9u9pts34rj.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox