public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2] api: workaround broken 'maxworkers' alias in bulk actions api calls
Date: Thu, 11 Dec 2025 14:11:58 +0100	[thread overview]
Message-ID: <176545871245.157948.11489765545313959210.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251205100317.1101549-1-d.csapak@proxmox.com>

On Fri, 05 Dec 2025 11:02:39 +0100, Dominik Csapak wrote:
> It seems, that 'alias' schema does not properly work currently for
> normal schema definitions (only for property-string), since it does not
> verification of the actual schema (checked by calling the api with
> maxworkers=1000, which throws no errors). Luckily, this is the only use
> of alias for api parameters that I could find. For the new cluster wide
> api calls it did not do anything, since we did not actually use
> `$param->{maxworkers}`, but for the node specific one broke the UI,
> since there we still send 'maxworkers', but the backend did not use that
> anymore.
> 
> [...]

Applied, thanks!

[1/1] api: workaround broken 'maxworkers' alias in bulk actions api calls
      commit: 60a0f0f0e81176c763f60c17c301791efda347d7


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-12-11 13:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-05 10:02 [pve-devel] " Dominik Csapak
2025-12-05 10:18 ` Dominik Csapak
2025-12-11 13:11 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176545871245.157948.11489765545313959210.b4-ty@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal