* [pve-devel] applied: [pbs-devel] [PATCH pve-xtermjs] Avoid allocating in `pre_exec` closure
[not found] <20251205124802.334198-1-yuki.utk8g@gmail.com>
@ 2025-12-09 16:25 ` Thomas Lamprecht
0 siblings, 0 replies; only message in thread
From: Thomas Lamprecht @ 2025-12-09 16:25 UTC (permalink / raw)
To: pve-devel, pbs-devel, Yuki Sireneva
On Fri, 05 Dec 2025 12:47:50 +0000, Yuki Sireneva wrote:
> `Error::new` allocates memory (see [148971]). This is bad in
> multi-threaded programs, which pve-xtermjs AFAIK is. If the fork occurs
> while the allocator lock is held by another thread, deadlocks can occur,
> since there's no one left in the new process to unlock the mutex.
> I do not believe this is UB, and modern libc offer protections against
> this issue, but this isn't POSIX-compliant and should preferably be
> avoided.
>
> [...]
Applied, thanks!
[1/1] Avoid allocating in `pre_exec` closure
commit: 41051f5a5e7bce513a6e0e31cacea44cab988391
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-12-09 16:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20251205124802.334198-1-yuki.utk8g@gmail.com>
2025-12-09 16:25 ` [pve-devel] applied: [pbs-devel] [PATCH pve-xtermjs] Avoid allocating in `pre_exec` closure Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox