[pve-devel] [PATCH manager] ui: bulk actions: don't try to reset non-existing 'vmidfilter'

[pve-devel] [PATCH manager] ui: bulk actions: don't try to reset non-existing 'vmidfilter'

[Dominik Csapak]

there never was a field with the id 'vmidfilter', so it was either a
left over from a previous attempt, or a copy&paste mistake.

It does not fix any behavior, since it was the last thing to be done in
the function anyway, but it prevents an exception/error log in the console.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
the diff does it not make it obvious, but it's just removing the 'vmid'
from the list. The linting/formatting rules change it afterwards.

 www/manager6/window/BulkAction.js | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/www/manager6/window/BulkAction.js b/www/manager6/window/BulkAction.js
index a6f90750..e51677e2 100644
--- a/www/manager6/window/BulkAction.js
+++ b/www/manager6/window/BulkAction.js
@@ -219,18 +219,11 @@ Ext.define('PVE.window.BulkAction', {
 
         let clearFilters = function () {
             me.down('#namefilter').setValue('');
-            [
-                'name',
-                'status',
-                'pool',
-                'type',
-                'hastate',
-                'includetag',
-                'excludetag',
-                'vmid',
-            ].forEach((filter) => {
-                me.down(`#${filter}filter`).setValue('');
-            });
+            ['name', 'status', 'pool', 'type', 'hastate', 'includetag', 'excludetag'].forEach(
+                (filter) => {
+                    me.down(`#${filter}filter`).setValue('');
+                },
+            );
         };
 
         let filterChange = function () {
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] ui: bulk actions: don't try to reset non-existing 'vmidfilter'

[Fiona Ebner]

On Mon, 17 Nov 2025 11:02:08 +0100, Dominik Csapak wrote:
> there never was a field with the id 'vmidfilter', so it was either a
> left over from a previous attempt, or a copy&paste mistake.
> 
> It does not fix any behavior, since it was the last thing to be done in
> the function anyway, but it prevents an exception/error log in the console.

Applied, thanks!

[1/1] ui: bulk actions: don't try to reset non-existing 'vmidfilter'
      commit: b4cd69554427987cce2d93a739957c04fc13d109


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel