public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH-SERIS qemu-server 0/4] vm start: ovmf: do not auto-enroll Microsoft UEFI CA 2023
Date: Tue, 18 Nov 2025 14:30:00 +0100	[thread overview]
Message-ID: <176347259808.1206474.115598923390616956.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251118123516.112546-1-f.ebner@proxmox.com>

On Tue, 18 Nov 2025 13:34:38 +0100, Fiona Ebner wrote:
> As reported in the community forum [0], enrolling the new certificate
> will trigger BitLocker recovery. It doesn't seem to be possible to
> detect whether BitLocker is used by looking at the EFI var store (no
> telling difference in dumps with 'virt-fw-vars --output-json' before
> and after).
> 
> Stop auto-enrolling the new Microsoft UEFI 2023 certificate and
> produce a warning, telling users about the 'qm enroll-efi-keys'
> command and what steps to take when BitLocker is used to avoid
> triggering recovery. Thomas found [1], which suggests using
> 'manage-bde -protectors -disable' which will disable key protectors
> for the next boot and this was also successfully tested.
> 
> [...]

Applied with two changes squashed in, thanks!

For one I replaced the log_warn with print for now to avoid being to noisy
already, we can "turn up the heat" for this early next year, e.g. for PVE 9.2.
Then I also moved new command out of the API, keeping it purely to the qm CLI
for now to avoid having to comit to this new API for the PVE 9 lifetime,
especially as we got some other ideas to handle this in a recent off list talk.

[1/4] ovmf: enroll ms 2023 cert: change QSD ID to allow calling outside of VM start
      commit: 4effab683fc9d0a4e85d9435d84fccff56e69101
[2/4] api/cli: add enroll-efi-keys endpoint
      commit: ee296e6eb10577ee90bfbb201beb5487bb81bda6
[3/4] ovmf: factor out helper for checking whether MS 2023 certificate should be enrolled
      commit: 16750f2a6023f1304e445beb2d9504d51c090bfc
[4/4] vm start: ovmf: do not auto-enroll Microsoft UEFI CA 2023
      commit: 6952b33bb976f3afe1369e7333e3aa3cc9dc2f1a


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-11-18 13:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 12:34 Fiona Ebner
2025-11-18 12:34 ` [pve-devel] [PATCH qemu-server 1/4] ovmf: enroll ms 2023 cert: change QSD ID to allow calling outside of VM start Fiona Ebner
2025-11-18 12:34 ` [pve-devel] [PATCH qemu-server 2/4] api/cli: add enroll-efi-keys endpoint Fiona Ebner
2025-11-18 12:58   ` Fabian Grünbichler
2025-11-18 13:07     ` Thomas Lamprecht
2025-11-18 13:09       ` Fabian Grünbichler
2025-11-18 14:11         ` Thomas Lamprecht
2025-11-18 12:34 ` [pve-devel] [PATCH qemu-server 3/4] ovmf: factor out helper for checking whether MS 2023 certificate should be enrolled Fiona Ebner
2025-11-18 12:34 ` [pve-devel] [PATCH qemu-server 4/4] vm start: ovmf: do not auto-enroll Microsoft UEFI CA 2023 Fiona Ebner
2025-11-18 13:30 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176347259808.1206474.115598923390616956.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal