From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, "Michael Köppl" <m.koeppl@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2 1/1] ui: create wizard: only submit ha-managed if checked for better compat
Date: Mon, 17 Nov 2025 22:25:59 +0100 [thread overview]
Message-ID: <176341475799.4174335.7454573949359906085.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251117173321.240894-1-m.koeppl@proxmox.com>
On Mon, 17 Nov 2025 18:33:21 +0100, Michael Köppl wrote:
> Avoid sending the parameter with the default value when it's not
> necessary, improving compatibility in cases where the ha-managed param
> is not recognized (e.g. when creating a guest on another node that does
> not support the parameter). Setting uncheckedValue to undefined results
> in the value of the checkbox not being submitted upon submission of the
> form if the checkbox is left unchecked or explicitly set unchecked [0].
> The API already considers the ha-managed param optional and sets a
> default value of 0.
>
> [...]
Applied, thanks!
[1/1] ui: create wizard: only submit ha-managed if checked for better compat
commit: d0c41ab177a2a374664fe75eda3133244b672f33
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-11-17 21:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 17:33 [pve-devel] " Michael Köppl
2025-11-17 21:25 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176341475799.4174335.7454573949359906085.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox