From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox-firewall/ve-rs v2 0/3] Fix ICMP types in nftables
Date: Mon, 17 Nov 2025 16:22:23 +0100 [thread overview]
Message-ID: <176339293942.3715717.5937451223335894824.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251006101933.90655-1-g.goller@proxmox.com>
On Mon, 06 Oct 2025 12:19:28 +0200, Gabriel Goller wrote:
> Currently when setting ICMP types on the old firewall (iptables) then
> switching to the new one (nftables) a few types will fail because they have
> been renamed in nftables or do not exist in nftables. This affects both icmp
> and icmpv6 where we now map options that do not exist in nftables to their
> respective type/code combinations. This allows us to have exactly the same
> behavior in nftables as we have in iptables.
>
> [...]
Applied, with the author reset to you for proxmox-ve-rs patch 1/2, thanks!
[1/1] tests: add icmpv6 type mapping test
commit 6a7063c44c6fc39ecdd725abc60e732bfcecdc04
[1/2] fix: firewall: introduce iptables to nftables mapping for icmp-types
commit: cfd2a9d4bd50bbfd47c7ca51d7ed4e50681eeb9f
[2/2] fix: firewall: introduce iptables to nftables mapping for icmpv6-types
commit: 884930e9355124103861632a3463e9f7eeb2a069
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-11-17 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 10:19 Gabriel Goller
2025-10-06 10:19 ` [pve-devel] [PATCH ve-rs v2 1/2] fix: firewall: introduce iptables to nftables mapping for icmp-types Gabriel Goller
2025-10-07 11:43 ` Gabriel Goller
2025-10-06 10:19 ` [pve-devel] [PATCH ve-rs v2 2/2] fix: firewall: introduce iptables to nftables mapping for icmpv6-types Gabriel Goller
2025-10-06 10:19 ` [pve-devel] [PATCH proxmox-firewall v2 1/1] tests: add icmpv6 type mapping test Gabriel Goller
2025-10-08 13:17 ` [pve-devel] [PATCH proxmox-firewall/ve-rs v2 0/3] Fix ICMP types in nftables Stefan Hanreich
2025-11-17 15:22 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176339293942.3715717.5937451223335894824.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox