public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager v2] www: sdn: improve naming of vm network device in bridge view
@ 2025-11-17 14:47 Gabriel Goller
  2025-11-17 14:52 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Gabriel Goller @ 2025-11-17 14:47 UTC (permalink / raw)
  To: pve-devel

When selecting a bridge we show all the ports and also decode the
firewall bridge port name. The name contaians the vmid and the vm
network device index. If we apply
https://lore.proxmox.com/pve-devel/20251117140121.160192-1-g.goller@proxmox.com/
the full interface name will be shown (`net{index}`), so this is a
better name for the column.

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---

Changelog v2, thanks @Thomas:
 * Change from "VM Network Device" -> "Guest Network Device" to be CT/VM
   generic.

 www/manager6/sdn/ZoneBridgesPanel.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/sdn/ZoneBridgesPanel.js b/www/manager6/sdn/ZoneBridgesPanel.js
index 600b23b0a8f8..8075f25b0851 100644
--- a/www/manager6/sdn/ZoneBridgesPanel.js
+++ b/www/manager6/sdn/ZoneBridgesPanel.js
@@ -76,7 +76,7 @@ Ext.define('PVE.sdn.ZoneBridgePortsPanel', {
             dataIndex: 'vmid',
         },
         {
-            text: gettext('Network Device Index'),
+            text: gettext('Guest Network Device'),
             flex: 1,
             sortable: true,
             dataIndex: 'index',
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager v2] www: sdn: improve naming of vm network device in bridge view
  2025-11-17 14:47 [pve-devel] [PATCH manager v2] www: sdn: improve naming of vm network device in bridge view Gabriel Goller
@ 2025-11-17 14:52 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-11-17 14:52 UTC (permalink / raw)
  To: pve-devel, Gabriel Goller

On Mon, 17 Nov 2025 15:47:53 +0100, Gabriel Goller wrote:
> When selecting a bridge we show all the ports and also decode the
> firewall bridge port name. The name contaians the vmid and the vm
> network device index. If we apply
> https://lore.proxmox.com/pve-devel/20251117140121.160192-1-g.goller@proxmox.com/
> the full interface name will be shown (`net{index}`), so this is a
> better name for the column.
> 
> [...]

Applied, thanks!

[1/1] www: sdn: improve naming of vm network device in bridge view
      commit: 16ace15c2fba2d7e69cba8c96c1a875cd8706492


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-17 14:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-17 14:47 [pve-devel] [PATCH manager v2] www: sdn: improve naming of vm network device in bridge view Gabriel Goller
2025-11-17 14:52 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal