* [pve-devel] [PATCH manager 1/1] fix: ui: trim OCI registry reference
@ 2025-11-17 12:45 Michael Köppl
2025-11-17 13:17 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Michael Köppl @ 2025-11-17 12:45 UTC (permalink / raw)
To: pve-devel
Trim the input such that an added space (e.g. from copying the URL from
a registry page) does not yield error "reference: value does not match
the regex pattern". Although true that the regex is then not matched,
this change avoids failing the validation due to an additional symbol
that can simply be trimmed.
Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
www/manager6/storage/TemplateView.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/storage/TemplateView.js b/www/manager6/storage/TemplateView.js
index 96313c1e5..207944585 100644
--- a/www/manager6/storage/TemplateView.js
+++ b/www/manager6/storage/TemplateView.js
@@ -216,7 +216,7 @@ Ext.define('PVE.storage.OciRegistryPull', {
let me = this;
let view = me.getView();
let refField = view.down('[name=reference]');
- let reference = refField.value;
+ let reference = refField.value.trim();
let tagField = view.down('[name=tag]');
Proxmox.Utils.API2Request({
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager 1/1] fix: ui: trim OCI registry reference
2025-11-17 12:45 [pve-devel] [PATCH manager 1/1] fix: ui: trim OCI registry reference Michael Köppl
@ 2025-11-17 13:17 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-11-17 13:17 UTC (permalink / raw)
To: pve-devel, Michael Köppl
On Mon, 17 Nov 2025 13:45:53 +0100, Michael Köppl wrote:
> Trim the input such that an added space (e.g. from copying the URL from
> a registry page) does not yield error "reference: value does not match
> the regex pattern". Although true that the regex is then not matched,
> this change avoids failing the validation due to an additional symbol
> that can simply be trimmed.
>
>
> [...]
Applied, thanks!
[1/1] fix: ui: trim OCI registry reference
commit: cf2876c2b46744b8b81cd5709fbfb4257abf23fd
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-17 13:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-17 12:45 [pve-devel] [PATCH manager 1/1] fix: ui: trim OCI registry reference Michael Köppl
2025-11-17 13:17 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox