From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit] pending object grid: don't fall back to empty string for 0 values
Date: Mon, 17 Nov 2025 13:59:53 +0100 [thread overview]
Message-ID: <176338439092.3569206.3711894799400085389.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251117112213.1387848-1-d.csapak@proxmox.com>
On Mon, 17 Nov 2025 12:21:00 +0100, Dominik Csapak wrote:
> if we have a value that is set to `0` (the number, not the string),
> the default pending object grid renderer would overwrite that with the
> empty string, since `0` does not evaluate to true.
>
> Instead, use the `Nullish coalescing operator` (??) to overwrite the
> value with only when it's null or undefined.
>
> [...]
Applied, thanks!
[1/1] pending object grid: don't fall back to empty string for 0 values
commit: 2a66b4ef7b993df4df1324f5a1158065c9467e70
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-11-17 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 11:21 [pve-devel] " Dominik Csapak
2025-11-17 12:59 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176338439092.3569206.3711894799400085389.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox