public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server master+stable-bookworm 1/1] fix #6934: vm start: don't apply pending changes when resuming from hibernation
Date: Mon, 17 Nov 2025 12:59:51 +0100	[thread overview]
Message-ID: <176338078415.3512763.16816754522752029962.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251029105325.40942-2-f.ebner@proxmox.com>

On Wed, 29 Oct 2025 11:53:07 +0100, Fiona Ebner wrote:
> When loading the VM state during resume from hibernation, it is
> essential that the QEMU commandline of the new instance matches the
> one from the instance the VM state was created with. Thus, pending
> changes cannot be applied.
> 
> Checking for hibernation was missing in the logic checking whether
> pending changes should be applied. In particular, the $statefile
> parameter is not used when resuming after hibernation. There, the
> $resume parameter is set and the state file/volume is found in the
> 'vmstate' configuraiton option.
> 
> [...]

Applied to master (with context conflict resolved) and stable-bookworm, thanks!

[1/1] fix #6934: vm start: don't apply pending changes when resuming from hibernation
      commit: 32445658fb38f59d21ad785ece0d2ccede8fe646


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-11-17 12:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29 10:53 [pve-devel] [PATCH qemu-server master+stable-bookworm 0/1] " Fiona Ebner
2025-10-29 10:53 ` [pve-devel] [PATCH qemu-server master+stable-bookworm 1/1] " Fiona Ebner
2025-11-17 11:59   ` Thomas Lamprecht [this message]
2025-11-17 10:45 ` [pve-devel] [PATCH qemu-server master+stable-bookworm 0/1] " Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176338078415.3512763.16816754522752029962.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal