From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, Shan Shaji <s.shaji@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox_dart_api_client v2] fix: ios: reorder on catch clauses to catch `NSErrorClientException`
Date: Fri, 24 Oct 2025 13:23:27 +0200 [thread overview]
Message-ID: <176130496926.2394528.620843850150610949.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251017113428.51347-1-s.shaji@proxmox.com>
On Fri, 17 Oct 2025 13:34:28 +0200, Shan Shaji wrote:
> The `NSErrorClientException` catch clause was not being executed because
> it's a subtype of `ClientException`. This resulted in showing the
> actual error from the package instead of our custom error message when
> the SSL/TLS handshake failed. Fixed the issue by reordering the on catch
> clauses.
>
>
> [...]
Applied, thanks!
[1/1] fix: ios: reorder on catch clauses to catch `NSErrorClientException`
commit: c5c2d90ba41f373bf5388b2ca4f06cb85be54218
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-10-24 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 11:34 [pve-devel] " Shan Shaji
2025-10-24 11:23 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176130496926.2394528.620843850150610949.b4-ty@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox