From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] vm status: make sure disk{read, write} adhere to return schema to fix regression for PDM
Date: Wed, 22 Oct 2025 13:50:24 +0200 [thread overview]
Message-ID: <176113381638.505211.14885999192908333519.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251022104259.47945-1-f.ebner@proxmox.com>
On Wed, 22 Oct 2025 12:41:15 +0200, Fiona Ebner wrote:
> As reported in the community forum [0], Proxmox Datacenter Manager
> will fail to handle the result of the status API call for a shut down
> VM. The reason is that the return schema requires having an integer
> return value for disk{read,write}, so an explicit undef is not
> allowed. However, the properties are optional and are not relevant for
> a shut down guest, so just don't set them at all if no value was
> queried. This also makes sure that bug #6207 does not reappear. Note
> that pvestatd would already not consider the value for shut down VMs
> and treats the value not being present and the value being an explicit
> undef the same, see update_qemu_status() in pvestatd.pm.
>
> [...]
Applied, thanks!
[1/1] vm status: make sure disk{read, write} adhere to return schema to fix regression for PDM
commit: 069d8a6e14d9524ae3f2c57ba7af3668721ddbc5
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-10-22 11:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 10:41 [pve-devel] " Fiona Ebner
2025-10-22 11:50 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176113381638.505211.14885999192908333519.b4-ty@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox