From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox-firewall v3 3/3] fix #6336: fix ipfilter matching logic
Date: Sat, 4 Oct 2025 14:58:47 +0200 [thread overview]
Message-ID: <175958267535.2042357.1930756777711278907.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251001162818.320717-5-s.hanreich@proxmox.com>
On Wed, 01 Oct 2025 18:28:16 +0200, Stefan Hanreich wrote:
> Matching on ipsets in the firewall generally works by matching on two
> sets (one for match, one for nomatch):
>
> ip saddr @ipfilter ip saddr != @ipfilter-nomatch <verdict>
>
> Ipfilters were created with the comparison operators simply inverted,
> which leads to ipfilters with empty nomatch sets never working, since
> the second expression always evaluates to false on empty sets:
>
> [...]
Applied, thanks!
[3/3] fix #6336: fix ipfilter matching logic
commit: 9b7295a311b71cfed50f716dd834f58693ed1dff
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-10-04 12:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 16:28 [pve-devel] [PATCH proxmox{-ve-rs, -firewall} v3 0/4] Fix ipfilters in proxmox-firewall Stefan Hanreich
2025-10-01 16:28 ` [pve-devel] [PATCH proxmox-ve-rs v3 1/1] config: guest: store network devices in BTreeMap Stefan Hanreich
2025-10-04 12:43 ` [pve-devel] applied: " Thomas Lamprecht
2025-10-01 16:28 ` [pve-devel] [PATCH proxmox-firewall v3 1/3] run rustfmt Stefan Hanreich
2025-10-04 12:58 ` [pve-devel] applied: " Thomas Lamprecht
2025-10-01 16:28 ` [pve-devel] [PATCH proxmox-firewall v3 2/3] ipfilter: fix wrong entries for containers Stefan Hanreich
2025-10-04 12:58 ` [pve-devel] applied: " Thomas Lamprecht
2025-10-01 16:28 ` [pve-devel] [PATCH proxmox-firewall v3 3/3] fix #6336: fix ipfilter matching logic Stefan Hanreich
2025-10-04 12:58 ` Thomas Lamprecht [this message]
2025-10-02 5:43 ` [pve-devel] [PATCH proxmox{-ve-rs, -firewall} v3 0/4] Fix ipfilters in proxmox-firewall Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175958267535.2042357.1930756777711278907.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox