public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, n.frey@proxmox.com
Subject: [pve-devel] partially-applied: [PATCH pve-manager v2 0/4] api: add return schemas
Date: Thu,  2 Oct 2025 10:23:28 +0200	[thread overview]
Message-ID: <175939340704.2551019.17686690400740948409.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250924115904.122696-1-n.frey@proxmox.com>

On Wed, 24 Sep 2025 13:59:00 +0200, n.frey@proxmox.com wrote:
> From: Nicolas Frey <n.frey@proxmox.com>
> 
> these four patches add the return schemas for endpoints in
> ACMEPlugin, APT, ReplicationConfig and Services using the
> createSchema() function where possible.
> Also tested functionality using pvesh.
> 
> [...]

Applied two of the four patches, will comment on the other two shortly, thanks!

Albeit I also squashed in a small change to the variable name to give them more
clarity, so that one reading the code can better tell what this is actually
used for, as just a _type prefix is rather opaque for these IMO.

[1/4] api: add ACME plugin return schema
      commit: 427e2627c0d19cf4907ae0157c84eef4a2d36764
[2/4] api: add APT versions return schema
      skipped for now
[3/4] api: add service state return schema
      commit: 35754e078debd8e5d1dffc1d67a291c31493289b
[4/4] api: add replication config read return schema
      skipped for now


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-10-02  8:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-24 11:59 [pve-devel] " n.frey
2025-09-24 11:59 ` [pve-devel] [PATCH pve-manager v2 1/4] api: add ACME plugin return schema n.frey
2025-09-24 11:59 ` [pve-devel] [PATCH pve-manager v2 2/4] api: add APT versions " n.frey
2025-10-02  8:50   ` Thomas Lamprecht
2025-10-02  9:25     ` Nicolas Frey
2025-09-24 11:59 ` [pve-devel] [PATCH pve-manager v2 3/4] api: add service state " n.frey
2025-09-24 11:59 ` [pve-devel] [PATCH pve-manager v2 4/4] api: add replication config read " n.frey
2025-10-02  8:51   ` Thomas Lamprecht
2025-10-02 11:18     ` Nicolas Frey
2025-10-02  8:23 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175939340704.2551019.17686690400740948409.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=n.frey@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal