From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Gabriel Goller <g.goller@proxmox.com>
Subject: [pve-devel] applied: [PATCH network] fix #6806: sdn: allow nic* and if* interfaces as bridge ports
Date: Tue, 16 Sep 2025 12:10:02 +0200 [thread overview]
Message-ID: <175801740046.1062983.2503653650676936059.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250915084801.48170-1-g.goller@proxmox.com>
On Mon, 15 Sep 2025 10:47:59 +0200, Gabriel Goller wrote:
> When creating a vlan zone and vnet, we get all the bridge interfaces
> (slaves) and add them to the new vlan bridge. We get all the bridge
> interfaces using `/sys/class/net` and then filter them using a regex.
> This regex was missing the new `if` and `nic` prefixes which were
> introduced with the pve-network-interface-pinning tool.
>
> This is more of a stop-gap, we can probably remove the regex completely
> as I don't see any reason to filter by "physical" interfaces here. If
> there is a need, we can still run `ip link` and check the attributes
> with `PVE::Network::ip_link_is_physical`.
>
> [...]
Applied, thanks!
[1/1] fix #6806: sdn: allow nic* and if* interfaces as bridge ports
commit: 4f19480b04315afb5dc23e0130463acaea35db18
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-09-16 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 8:47 [pve-devel] " Gabriel Goller
2025-09-15 10:42 ` Thomas Lamprecht
2025-09-15 10:51 ` Gabriel Goller
2025-09-16 10:10 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175801740046.1062983.2503653650676936059.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox