From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Gabriel Goller <g.goller@proxmox.com>
Subject: [pve-devel] applied: [PATCH network] frr: print task warning when frr reload fails
Date: Tue, 16 Sep 2025 12:10:03 +0200 [thread overview]
Message-ID: <175801740046.1062983.11034703970346131532.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250911153359.278834-1-g.goller@proxmox.com>
On Thu, 11 Sep 2025 17:33:54 +0200, Gabriel Goller wrote:
> Instead of just printing a normal warning, use log_warn, which adds a
> warning to the whole task. This means the whole task ends with a
> "warning" status which is visible nicely in the task list. Previously we
> just printed a warning, which made the task end with "OK" even if the
> reload failed.
>
> frr-reload.py only fails if it's not installed (where a warning status
> is ok) or the configuration is not valid (where a warning status is also
> ok). Having frr-reload.py uninstalled for some reason and always relying
> on `systemctl restart frr` to reload the sdn config is kinda weird and
> you probably deserve to get a warning on each sdn apply task.
>
> [...]
Applied, thanks!
[1/1] frr: print task warning when frr reload fails
commit: ea13baa9af4cff1c2dbc096a757b4c0a94afaa56
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-09-16 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 15:33 [pve-devel] " Gabriel Goller
2025-09-11 15:52 ` Gabriel Goller
2025-09-16 10:10 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175801740046.1062983.11034703970346131532.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox