public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH docs] pvecm: redundancy: explicitly mention subnets
@ 2025-09-08 14:52 Friedrich Weber
  2025-09-09 13:12 ` Maximiliano Sandoval
  2025-09-09 15:38 ` [pve-devel] applied: " Fiona Ebner
  0 siblings, 2 replies; 3+ messages in thread
From: Friedrich Weber @ 2025-09-08 14:52 UTC (permalink / raw)
  To: pve-devel

The section uses addresses 10.10.10.X and 10.20.20.X in examples and
implicitly assumes they are in disjoint subnets, but does not
explicitly state this.

For better clarity, explicitly mention these are /25 subnets (this
subnet mask is also used in the "Separate Cluster Network" section).

Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---

Notes:
    Reported in enterprise support as potentially confusing.

 pvecm.adoc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/pvecm.adoc b/pvecm.adoc
index 5258038..10b4b16 100644
--- a/pvecm.adoc
+++ b/pvecm.adoc
@@ -908,6 +908,9 @@ adding a new node) or by specifying more than one 'ringX_addr' in
 NOTE: To provide useful failover, every link should be on its own
 physical network connection.
 
+The following examples assume that each cluster node has one static address in
+10.10.10.0/25 and one static address in 10.20.20.0/25 configured.
+
 Links are used according to a priority setting. You can configure this priority
 by setting 'knet_link_priority' in the corresponding interface section in
 `corosync.conf`, or, preferably, using the 'priority' parameter when creating
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] [PATCH docs] pvecm: redundancy: explicitly mention subnets
  2025-09-08 14:52 [pve-devel] [PATCH docs] pvecm: redundancy: explicitly mention subnets Friedrich Weber
@ 2025-09-09 13:12 ` Maximiliano Sandoval
  2025-09-09 15:38 ` [pve-devel] applied: " Fiona Ebner
  1 sibling, 0 replies; 3+ messages in thread
From: Maximiliano Sandoval @ 2025-09-09 13:12 UTC (permalink / raw)
  To: Friedrich Weber; +Cc: pve-devel

Friedrich Weber <f.weber@proxmox.com> writes:

> The section uses addresses 10.10.10.X and 10.20.20.X in examples and
> implicitly assumes they are in disjoint subnets, but does not
> explicitly state this.
>
> For better clarity, explicitly mention these are /25 subnets (this
> subnet mask is also used in the "Separate Cluster Network" section).
>
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>

Looks good to me.

Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

-- 
Maximiliano


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH docs] pvecm: redundancy: explicitly mention subnets
  2025-09-08 14:52 [pve-devel] [PATCH docs] pvecm: redundancy: explicitly mention subnets Friedrich Weber
  2025-09-09 13:12 ` Maximiliano Sandoval
@ 2025-09-09 15:38 ` Fiona Ebner
  1 sibling, 0 replies; 3+ messages in thread
From: Fiona Ebner @ 2025-09-09 15:38 UTC (permalink / raw)
  To: pve-devel, Friedrich Weber

On Mon, 08 Sep 2025 16:52:24 +0200, Friedrich Weber wrote:
> The section uses addresses 10.10.10.X and 10.20.20.X in examples and
> implicitly assumes they are in disjoint subnets, but does not
> explicitly state this.
> 
> For better clarity, explicitly mention these are /25 subnets (this
> subnet mask is also used in the "Separate Cluster Network" section).
> 
> [...]

Applied, thanks!

[1/1] pvecm: redundancy: explicitly mention subnets
      commit: feb34c347cd55ff31c99f39d077058f087e5dc5c


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-09-09 15:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-08 14:52 [pve-devel] [PATCH docs] pvecm: redundancy: explicitly mention subnets Friedrich Weber
2025-09-09 13:12 ` Maximiliano Sandoval
2025-09-09 15:38 ` [pve-devel] applied: " Fiona Ebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal