From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: storage edit: warn about disabling snapshot-as-volume-chain on LVM
Date: Tue, 12 Aug 2025 12:23:24 +0200 [thread overview]
Message-ID: <175499418991.342339.17786692765339035462.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250812082824.30625-1-f.ebner@proxmox.com>
On Tue, 12 Aug 2025 10:28:14 +0200, Fiona Ebner wrote:
> Existing qcow2 volumes on a storage won't be handled correctly anymore
> after the setting is turned off. The setting is already a fixed
> storage setting for directory-based storages, so this is only relevant
> for LVM. Could be improved by checking in the backend if there are any
> qcow2 images and only allow turning it off if not, but this requires
> changes to the on_update_hook() signature. Until then, warn in the
> front-end.
>
> [...]
Applied, thanks!
[1/1] ui: storage edit: warn about disabling snapshot-as-volume-chain on LVM
commit: d77a90c471677fe24957998d779c3e177cc4349e
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-12 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 8:28 [pve-devel] " Fiona Ebner
2025-08-12 10:23 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175499418991.342339.17786692765339035462.b4-ty@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox